Bug#983637: tracker-extract: Add newfstat() to syscall list

[Guido Günther]

Hi,
On Sat, Feb 27, 2021 at 05:16:04PM +0100, Julian Andres Klode wrote:
> Package: tracker-miners
> Version: 2.3.5-2
> Severity: normal
> Tags: patch
> User: ubuntu-devel at lists.ubuntu.com
> Usertags: origin-ubuntu hirsute ubuntu-patch
> X-Debbugs-Cc: juliank at ubuntu.com
> 
> In Ubuntu, the attached patch was applied to achieve the following:
> 
> Fix tracker-extract crashing constantly with new glibc.

I somehow missed this bug when preparing

https://salsa.debian.org/gnome-team/tracker-miners/-/merge_requests/14

but i can confirm missing 'newfsstat` crashes the miner constantly like

Program terminated with signal SIGSYS, Bad system call.
#0  __GI___xstat (vers=<optimized out>, name=0xffff803cd178 "/etc/localtime", buf=0xffff4ae26bd0) at ../sysdeps/unix/sysv/linux/generic/xstat.c:36
36	../sysdeps/unix/sysv/linux/generic/xstat.c: No such file or directory.
[Current thread is 1 (Thread 0xffff4ae28050 (LWP 3217))]
(gdb) bt
#0  __GI___xstat (vers=<optimized out>, name=0xffff803cd178 "/etc/localtime", buf=0xffff4ae26bd0) at ../sysdeps/unix/sysv/linux/generic/xstat.c:36
#1  0x0000ffff8033411c in __tzfile_read (file=file at entry=0xffff803cd178 "/etc/localtime", extra=extra at entry=0, extrap=extrap at entry=0x0) at tzfile.c:155
#2  0x0000ffff80333cd0 in tzset_internal (always=always at entry=1) at tzset.c:405
#3  0x0000ffff80333e14 in __tzset () at tzset.c:551
#4  0x0000ffff80332b14 in __GI_mktime (tp=tp at entry=0xffff4ae26d00) at mktime.c:529
#5  0x0000ffff8094e7a0 in tracker_date_format_to_iso8601 (date_string=date_string at entry=0xffff4ae26d68 "2021:04:26 16:10:14", format=format at entry=0xffff80952200 "%Y:%m:%d %H:%M:%S")
    at ../src/libtracker-extract/tracker-utils.c:464
#6  0x0000ffff8094a4a8 in get_date (exif=exif at entry=0xffff2c00ff20, tag=tag at entry=EXIF_TAG_DATE_TIME) at ../src/libtracker-extract/tracker-exif.c:83
#7  0x0000ffff8094b154 in parse_exif (buffer=buffer at entry=0xffff2c014840 "Exif", len=len at entry=342, data=data at entry=0xffff2c00f6e0, uri=0xffff2c0105d0 "file:///home/purism/Pictures/IMG20210426161014.jpg")
    at ../src/libtracker-extract/tracker-exif.c:478
#8  0x0000ffff8094bc7c in tracker_exif_new (buffer=buffer at entry=0xffff2c014840 "Exif", len=len at entry=342, uri=uri at entry=0xffff2c0105d0 "file:///home/purism/Pictures/IMG20210426161014.jpg")
    at ../src/libtracker-extract/tracker-exif.c:614
#9  0x0000ffff7c32faec in tracker_extract_get_metadata (info=0xaaaad820b040) at ../src/tracker-extract/tracker-extract-jpeg.c:230
#10 0x0000aaaab303f620 in get_file_metadata (task=task at entry=0xaaaad850f590, info_out=info_out at entry=0xffff4ae277e0) at ../src/tracker-extract/tracker-extract.c:302
#11 0x0000aaaab303fd80 in get_metadata (task=0xaaaad850f590) at ../src/tracker-extract/tracker-extract.c:511
#12 0x0000aaaab303fdd4 in single_thread_get_metadata (queue=0xaaaad8515200) at ../src/tracker-extract/tracker-extract.c:539
#13 0x0000ffff805468f4 in g_thread_proxy (data=0xaaaad8522a40) at ../../../glib/gthread.c:820
#14 0x0000ffff80419628 in start_thread (arg=0xffff4ae27950) at pthread_create.c:477
#15 0x0000ffff8037101c in thread_start () at ../sysdeps/unix/sysv/linux/aarch64/clone.S:78

and with the above it fixes it for me. The bug should likely have a
higher priority since when e.g. systemd-coredump is installed as well
the crash every 2s and writing the core file is a real battery drain.

Cheers,
 -- Guido