Bug#984953: libgtkmm-3.0-1v5: GParted crashes on Gdk::Pixbuf::get_width() const ()

[Simon McVittie]

Control: reassign -1 gparted 1.2.0-1

On Thu, 25 Mar 2021 at 22:22:33 +0100, Bernhard Übelacker wrote:
> In the end it looks like in refresh_combo_devices [2] it
> is attempted to load a harddisk icon.
> 
> This failed for some reason in [3], therefore a local variable
> "theme_icon" contains a null pointer, which gets unconditionally
> called member function get_width on and therefore
> crashes a few lines later.

This looks like a gparted bug, rather than a libgtkmm-3.0-1v5 bug.
GParted::Utils::mk_pixbuf calls Gtk::Widget::render_icon_pixbuf,
presumably a wrapper around gtk_widget_render_icon_pixbuf(), which
is documented to return NULL if the "stock ID" is not known (as it
presumably is in this case); but then it calls theme_icon->get_width()
and theme_icon->get_height() without first checking whether theme_icon is
a null pointer.

gtk_widget_render_icon_pixbuf() is documented as having been deprecated
since GTK 3.10, released in 2013. The recommended replacement is
gtk_icon_theme_load_icon().

    smcv