Bug#988951: regression: focus_path on last items no longer works properly

[Cyril Brulebois]

Cyril Brulebois <kibi at debian.org> (2021-05-23):
> And right before getting some rest, it struck me that I should be
> looking into the size-request and size-allocate signals. The latter is
> the right one and that's indeed getting me the focus where it should be!
> \o/ I suppose this isn't entirely crazy since that's an idea you had as
> well. :)
> 
> … back to MR #12, I'm a little reluctant to changing the workaround at
> this stage. After all, I've run a bunch of test cases already, which all
> looked good, and while reverting the initial workaround would mean less
> code / technical debt, all those lines should go away in bookworm
> anyway. So I think I would *slightly* prefer paper over the focus
> regression (this bug) with an extra callback. I would have to need to
> power up coffee and brain a little more though. :)

Apart from introducing a memory leak, that alone is sufficient to fix
the glitch:
  https://salsa.debian.org/installer-team/cdebconf/-/merge_requests/13

For reference, here's what size-allocate events can look like. For the
avoidance of doubt, I logged x,y and w(idth),h(eight) on two separate
lines to ease comparing values, but each x,y + w,h couple of lines
come from the same size-allocate event (a GdkRectangle is provided):

    May 23 19:57:01 debconf: ----- update title ----- ← mirror country selection
    May 23 19:57:01 debconf: allocate: x,y=8x49
    May 23 19:57:01 debconf: allocate: w,h=208x60
    May 23 19:57:01 debconf: allocate: x,y=8x49
    May 23 19:57:01 debconf: allocate: w,h=722x368
    May 23 19:57:01 debconf: allocate: x,y=8x49
    May 23 19:57:01 debconf: allocate: w,h=740x368
    May 23 19:57:01 debconf: allocate: x,y=8x81
    May 23 19:57:01 debconf: allocate: w,h=740x336
    May 23 19:57:02 debconf: ----- update title ----- ← mirror hostname selection
    May 23 19:57:02 debconf: allocate: x,y=8x49
    May 23 19:57:02 debconf: allocate: w,h=241x60
    May 23 19:57:02 debconf: allocate: x,y=8x49
    May 23 19:57:02 debconf: allocate: w,h=722x368
    May 23 19:57:02 debconf: allocate: x,y=8x49
    May 23 19:57:02 debconf: allocate: w,h=740x368
    May 23 19:57:02 debconf: allocate: x,y=8x66
    May 23 19:57:02 debconf: allocate: w,h=740x351
    May 23 19:57:02 debconf: allocate: x,y=8x95
    May 23 19:57:02 debconf: allocate: w,h=740x322
    May 23 19:57:02 debconf: ----- update title ----- ← proxy => Back
    May 23 19:57:04 debconf: ----- update title ----- ← mirror hostname selection again
    May 23 19:57:04 debconf: allocate: x,y=8x49
    May 23 19:57:04 debconf: allocate: w,h=241x60
    May 23 19:57:04 debconf: allocate: x,y=8x49
    May 23 19:57:04 debconf: allocate: w,h=722x368
    May 23 19:57:04 debconf: allocate: x,y=8x49
    May 23 19:57:04 debconf: allocate: w,h=740x368
    May 23 19:57:04 debconf: allocate: x,y=8x66
    May 23 19:57:04 debconf: allocate: w,h=740x351
    May 23 19:57:04 debconf: allocate: x,y=8x95
    May 23 19:57:04 debconf: allocate: w,h=740x322


Cheers,
-- 
Cyril Brulebois (kibi at debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-gnome-maintainers/attachments/20210523/e6f2acf5/attachment.sig>