Bug#1027308: chezdav: should probably depend on or recommend avahi-daemon

[Andreas Henriksson]

Hello Andres Salomon,

Thanks for your bug report! comments below.

On Thu, Dec 29, 2022 at 11:55:25PM -0500, Andres Salomon wrote:
> Package: chezdav
> Version: 2.5-1
> Severity: normal
> 
> I installed chezdav on a bullseye server, and here's what got installed:
[...]
> Note that avahi-daemon was not already installed on the server. When I
> attemped to run it:
> 
> 
> dilinger at hm90:~$ chezdav -P /srv/shared/
> phodav: mDNS failed: Failed to create avahi client: Daemon not running

Relevant code:
https://gitlab.gnome.org/GNOME/phodav/-/blob/a31d890d4805291d9f4af82bf43279ad4fb76059/bin/chezdav.c#L201-205

We're enabling the AVAHI build option in the debian package build
(by having the required build-dependencies for it and also specifying
the `-Dauto_features=enabled` in debian/rules).

So apparently when built with avahi support, failures to contact
the daemon is considered a fatal error (which spontaneously I thought
would be better as just a warning, since this is an optional feature in
the first place?!).... unless the user explicitly passes the --no-mdns
option to disable mdns usage (so I guess it makes sense after all).

> After installing avahi-daemon, the command worked successfully. It should
> probably either depend upon or recommend avahi-daemon.

Since there's a runtime switch to override mdns I'll add it as a
Recommends.

Regards,
Andreas Henriksson