Bug#1013672: g-s-custom-session: redundant because 'g-s-selector' is not installed

[Akbarkhon Variskhanov]

Package: gnome-session-bin
Version: 42.0-1
Severity: wishlist
File: /usr/bin/gnome-session-custom-session
Tags: patch
X-Debbugs-Cc: akbarkhon.variskhanov at gmail.com

Dear Maintainer,

Out of sheer curiosity, I ran 'g-s-c-s' to see what it does.
To my surprise and wonder, it killed the active session.
After examination, it was clear that 'g-s-c-s' cannot accomplish its task
because 'g-s-selector' is not installed with the package.
If it was shipped, the script would run just fine. 'g-s-c-s' does not
protect against this scenario and goes on to execute the next line,
which ends the session abruptly.

It is unclear whether the exclusion of 'g-s-selector' from the package
is intentional. If it is, then 'g-s-c-s' should be removed from
'd/g-s-bin.install', as it has no use in this case, since it depends on
'g-s-selector'. If it's unintentional and an oversight, then the
"enable_session_selector" flag should be enabled for the build.

In the meantime, a quick fix is to add an AND list operator between the
two commands.

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.18.0-2-amd64 (SMP w/1 CPU thread; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages gnome-session-bin depends on:
ii  dbus-user-session [default-dbus-session-bus]  1.14.0-1
ii  dbus-x11 [dbus-session-bus]                   1.14.0-1
ii  dconf-gsettings-backend [gsettings-backend]   0.40.0-3
ii  gsettings-desktop-schemas                     42.0-1
ii  libc6                                         2.33-7
ii  libegl1                                       1.4.0-1
ii  libepoxy0                                     1.5.10-1
ii  libgl1                                        1.4.0-1
ii  libgles2                                      1.4.0-1
ii  libglib2.0-0                                  2.72.2-2
ii  libgnome-desktop-3-19                         42.2-1
ii  libgtk-3-0                                    3.24.34-1
ii  libice6                                       2:1.0.10-1
ii  libjson-glib-1.0-0                            1.6.6-1
ii  libsm6                                        2:1.2.3-1
ii  libsystemd0                                   251.2-6
ii  libx11-6                                      2:1.7.5-1
ii  libxcomposite1                                1:0.4.5-1
ii  upower                                        0.99.19-1
ii  xwayland                                      2:22.1.2-1

Versions of packages gnome-session-bin recommends:
ii  libpam-systemd [logind]  251.2-6

gnome-session-bin suggests no packages.

-- no debconf information
-------------- next part --------------
--- gnome-session-custom-session.orig	2022-06-25 00:22:37.822948061 +0500
+++ gnome-session-custom-session.fixed	2022-06-25 00:21:36.890228426 +0500
@@ -1,4 +1,3 @@
-#! /bin/sh
+#!/bin/sh
 
-gnome-session-selector
-exec gnome-session
+gnome-session-selector && exec gnome-session