Bug#1022765: gnome-passwordsafe: Crash when opening a database (presumably because {} is in custom_property field)

[Krassy Boykinov]

Package: gnome-passwordsafe
Version: 6.5-5
Severity: important

Crashes when opening my file with ~50 entries and comments for a lot of
them

This happened after updating pykeepass yesterday
> 2022-10-24 11:50:54 upgrade python3-pykeepass:all 4.0.1-1 4.0.3-1

Creating a new empty database and unlocking it later on does not cause
any problems

Here is a syslog excerpt
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]: 
Traceback (most recent call last):
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]:   File 
"/usr/lib/python3/dist-packages/gsecrets/unlock_database.py", line 270, 
in _unlock_callback
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]: 
database = UnlockedDatabase(self.window, database_manager)
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]:   File 
"/usr/lib/python3/dist-packages/gsecrets/unlocked_database.py", line 99, 
in __init__
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]: 
self.show_browser_page(self.current_element)
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]:   File 
"/usr/lib/python3/dist-packages/gsecrets/unlocked_database.py", line 
178, in show_browser_page
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]: 
new_page = UnlockedDatabasePage(self, group)
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]:   File 
"/usr/lib/python3/dist-packages/gsecrets/widgets/unlocked_database_page.py", 
line 60, in __init__
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]: 
self.populate_list_model()
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]:   File 
"/usr/lib/python3/dist-packages/gsecrets/widgets/unlocked_database_page.py", 
line 180, in populate_list_model
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]: 
entries = self.group.entries
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]:   File 
"/usr/lib/python3/dist-packages/gsecrets/safe_element.py", line 288, in 
entries
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]: 
return [SafeEntry(self._db_manager, entry) for entry in self._group.entries]
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]:   File 
"/usr/lib/python3/dist-packages/gsecrets/safe_element.py", line 288, in 
<listcomp>
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]: 
return [SafeEntry(self._db_manager, entry) for entry in self._group.entries]
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]:   File 
"/usr/lib/python3/dist-packages/gsecrets/safe_element.py", line 330, in 
__init__
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]: 
otp_uri = entry.get_custom_property("otp")
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]:   File 
"/usr/lib/python3/dist-packages/pykeepass/entry.py", line 255, in 
get_custom_property
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]: 
assert key not in reserved_keys, '{} is a reserved key'.format(key)
 > Okt 25 13:21:15 machine org.gnome.World.Secrets.desktop[6808]: 
AssertionError: otp is a reserved key

-- System Information:
Debian Release: bookworm/sid
   APT prefers unstable
   APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.0.0-2-amd64 (SMP w/2 CPU threads; PREEMPT)
Kernel taint flags: TAINT_CPU_OUT_OF_SPEC
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE 
not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages gnome-passwordsafe depends on:
ii  secrets  6.5-5

gnome-passwordsafe recommends no packages.

gnome-passwordsafe suggests no packages.

-- no debconf information