Bug#1043740: cairo: Fails to build source after successful build

[Lucas Nussbaum]

Source: cairo
Version: 1.16.0-7
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package cairo
> dpkg-buildpackage: info: source version 1.16.0-7
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Jeremy Bicha <jbicha at ubuntu.com>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    debian/rules execute_before_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> rm -f test/reference/bug-image-compositor.ref.png
> rm -rf debian/install/ debian/build/
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean
>    dh_gnome_clean
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building cairo using existing ./cairo_1.16.0.orig.tar.xz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: ignoring deletion of file aclocal.m4, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file configure, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file config.h.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file perf/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file perf/micro/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file test/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file test/pdiff/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file boilerplate/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file build/ltsugar.m4, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file build/ar-lib, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file build/install-sh, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file build/lt~obsolete.m4, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file build/compile, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file build/ltmain.sh, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file build/ltversion.m4, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file build/depcomp, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file build/libtool.m4, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file build/test-driver, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file build/missing, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file build/ltoptions.m4, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file doc/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file doc/public/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file util/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file util/cairo-missing/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file util/cairo-script/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file util/cairo-script/examples/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file util/cairo-gobject/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file util/cairo-fdr/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file util/cairo-sphinx/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file util/cairo-trace/Makefile.in, use --include-removal to override
> dpkg-source: info: local changes detected, the modified files are:
>  cairo-1.16.0/boilerplate/Makefile.am.features
>  cairo-1.16.0/boilerplate/Makefile.win32.features
>  cairo-1.16.0/build/Makefile.win32.features
>  cairo-1.16.0/build/Makefile.win32.features-h
>  cairo-1.16.0/src/Makefile.am.features
>  cairo-1.16.0/src/Makefile.win32.features
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/cairo_1.16.0-7.diff.nkDuhp
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/cairo_1.16.0-7_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.