Bug#1044991: gtk4: Fails to build source after successful build

[Lucas Nussbaum]

Source: gtk4
Version: 4.10.5+ds-3
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package gtk4
> dpkg-buildpackage: info: source version 4.10.5+ds-3
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Simon McVittie <smcv at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean --with gir --buildsystem=meson 
>    dh_auto_clean -O--buildsystem=meson
>    dh_autoreconf_clean -O--buildsystem=meson
>    debian/rules override_dh_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> # gross kludge to force control generation with the %.in target
> touch debian/control.in
> rm -f debian/libgtk-4-1.postinst debian/libgtk-4-1.postrm debian/libgtk-4-1.symbols debian/libgtk-4-1.triggers debian/libgtk-4-doc.doc-base.gdk-wayland debian/libgtk-4-doc.doc-base.gdk-x11 debian/libgtk-4-doc.doc-base.gdk debian/libgtk-4-doc.doc-base.gsk debian/libgtk-4-doc.doc-base.gtk
> rm -rf debian/build debian/install
> # Rebuild the CSS from source. Note that gtk.css is hand-written,
> # not generated, so don't delete that one.
> rm -f gtk/theme/Default/Default-*.css
> dh_clean
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building gtk4 using existing ./gtk4_4.10.5+ds.orig.tar.xz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  gtk4-4.10.5+ds/po/gtk40.pot
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/gtk4_4.10.5+ds-3.diff.HndFQD
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/gtk4_4.10.5+ds-3_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.