Bug#1050075: (no subject)

Nathan Teodósio nathan.teodosio at canonical.com
Tue Aug 22 11:54:02 BST 2023


I'm proposing disabling those tests as they were deemed flaky by upstream.
-------------- next part --------------
diff -Nru gtk4-4.12.0+ds/debian/changelog gtk4-4.12.0+ds/debian/changelog
--- gtk4-4.12.0+ds/debian/changelog	2023-08-08 23:31:01.000000000 +0200
+++ gtk4-4.12.0+ds/debian/changelog	2023-08-22 12:50:15.000000000 +0200
@@ -1,3 +1,10 @@
+gtk4 (4.12.0+ds-2) experimental; urgency=medium
+
+  * d/p/disable-checkerboard-reftests.patch:
+    - Disable flaky build-time checkerboard tests (closes #1050075).
+
+ -- Nathan Pratta Teodosio <nathan.teodosio at canonical.com>  Tue, 22 Aug 2023 12:50:15 +0200
+
 gtk4 (4.12.0+ds-1) experimental; urgency=medium
 
   * New upstream release
diff -Nru gtk4-4.12.0+ds/debian/patches/debian/disable-checkerboard-reftests.patch gtk4-4.12.0+ds/debian/patches/debian/disable-checkerboard-reftests.patch
--- gtk4-4.12.0+ds/debian/patches/debian/disable-checkerboard-reftests.patch	1970-01-01 01:00:00.000000000 +0100
+++ gtk4-4.12.0+ds/debian/patches/debian/disable-checkerboard-reftests.patch	2023-08-22 12:48:23.000000000 +0200
@@ -0,0 +1,22 @@
+Description: Disable flaky checkerboard tests.
+ .
+ gitlab.gnome.org/GNOME/gtk/-/commit/a235b59089a7fe2d7957f20bcd2a67f9aef2f724
+ gitlab.gnome.org/GNOME/gtk/-/commit/5e8e4130a51f8d1f599ee74360c5e9126ff40d48
+ .
+ "When textures are too large, we will scale them down to fit the max texture
+ size, which will cause comparisons to fail."
+Author: Nathan Pratta Teodosio <nathan.teodosio at canonical.com>
+Forwarded: not-needed
+Bug-Ubuntu: https://launchpad.net/bugs/2032638
+Date: Tue, 22 Aug 2023 11:59:21 +0200
+
+--- a/testsuite/gsk/meson.build
++++ b/testsuite/gsk/meson.build
+@@ -11,7 +11,5 @@
+ compare_render_tests = [
+   'big-checkerboard',
+-  'big-checkerboard-scaled-down',
+   'big-checkerboard-scaled-down-nearest',
+-  'big-checkerboard-scaled-down2',
+   'blend-difference',
+   'blend-modes',
diff -Nru gtk4-4.12.0+ds/debian/patches/series gtk4-4.12.0+ds/debian/patches/series
--- gtk4-4.12.0+ds/debian/patches/series	2023-08-08 23:31:01.000000000 +0200
+++ gtk4-4.12.0+ds/debian/patches/series	2023-08-22 12:49:55.000000000 +0200
@@ -10,3 +10,4 @@
 debian/gstreamer-player-1.0-Do-not-install-it-if-it-s-a-subproje.patch
 debian/media-Use-gstplayer-from-meson-subproject.patch
 debian/gstreamer-player-Use-GtkName-Prefix-to-avoid-issues-if-ac.patch
+debian/disable-checkerboard-reftests.patch


More information about the pkg-gnome-maintainers mailing list