Bug#1027671: intltool: Bogus UTF-8 output

[Samuel Thibault]

Package: intltool
Version: 0.51.0-6
Severity: important

Hello,

With the newer perl version in bookworm, reading/emitting utf-8 is
apparently not enabled by default any more. In the choose-mirror
package, we had to apply the attached patch, otherwise the output was
buggy, see https://lists.debian.org/debian-boot/2023/01/msg00018.html

intltool very probably needs the same fix.

Samuel

-- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'stable-security'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 'proposed-updates'), (500, 'oldstable-proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, arm64

Kernel: Linux 6.1.0 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages intltool depends on:
ii  automake [automaken]      1:1.16.5-1.3
ii  automake1.11 [automaken]  1:1.11.6-6
ii  file                      1:5.41-4
ii  gettext                   0.21-10
ii  libxml-parser-perl        2.46-4
ii  patch                     2.7.6-7
ii  perl                      5.36.0-6

intltool recommends no packages.

intltool suggests no packages.

-- no debconf information

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.
-------------- next part --------------
commit 04a0e1fba4b088b877b4f26d1ce675009a31ae23
Author: Samuel Thibault <sthibault at debian.org>
Date:   Sun Jan 1 17:13:11 2023 +0100

    intltool-merge: Fix emitting utf8 templates

diff --git a/debian/changelog b/debian/changelog
index be15eb2..1537b7d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+choose-mirror (2.116) unstable; urgency=medium
+
+  * intltool-merge: Fix emitting utf8 templates.
+
+ -- Samuel Thibault <sthibault at debian.org>  Sun, 01 Jan 2023 17:03:59 +0100
+
 choose-mirror (2.115) unstable; urgency=medium
 
   * Team upload
diff --git a/intltool-merge b/intltool-merge
index 6bfc807..b878efc 100755
--- a/intltool-merge
+++ b/intltool-merge
@@ -393,13 +393,13 @@ sub create_translation_database
 
             if (lc $encoding eq "utf-8") 
             {
-                open PO_FILE, "<$po_file";	
+                open PO_FILE, "<:utf8", "$po_file";
             } 
             else 
             {
 		print STDERR "WARNING: $po_file is not in UTF-8 but $encoding, converting...\n" unless $QUIET_ARG;;
 
-                open PO_FILE, "$iconv -f $encoding -t UTF-8 $po_file|";	
+                open PO_FILE, "-|:utf8", "$iconv -f $encoding -t UTF-8 $po_file";
             }
         } 
         else 
@@ -1205,12 +1205,12 @@ sub rfc822deb_merge_translations
 
     {
        local $/; # slurp mode
-       open INPUT, "<$FILE" or die "can't open $FILE: $!";
+       open INPUT, "<:utf8", "$FILE" or die "can't open $FILE: $!";
        $source = <INPUT>;
        close INPUT;
     }
 
-    open OUTPUT, ">${OUTFILE}" or die;
+    open OUTPUT, ">:utf8", "${OUTFILE}" or die;
 
     #  Remove comments
     $source =~ s/^#[^\n]*(\n|$)//s;