Bug#1037514: gnome-video-effects: The flip effect isnt work due to property method being deprecated

[Phelipe Matheus Couto de Aguiar]

Package: gnome-video-effects
Version: 0.5.0
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu mantic ubuntu-patch

Dear Maintainer, I was using Cheese and the main effect should be
the flip effect, and I realise that it wasn't working, not even in
the effects table. So I investigated and saw that the problems where
located in /usr/share/gnome-video-effects/flip.effect that videoflip was
using a deprecated property which is method, the new one is called
video-direction, this changes can be seen in GStreamer documentations.



*** /tmp/tmpr4d_w7n2/bug_body

It was seen that even in Debian 12(bookworm) this problem was
persisting, and the same fix work to Deb12.


  * debian/patches/01-fix-for-flip-effect.patch:
    - The property method of video-flip is deprecated
      so its necessary to change to the new one which
      is video-direction. You can see this changes in
      GStreamer documentation. (LP: #2023675)


Thanks for considering the patch.


-- System Information:
Debian Release: bookworm/sid
  APT prefers lunar-updates
  APT policy: (500, 'lunar-updates'), (500, 'lunar-security'), (500, 'lunar'), (100, 'lunar-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 6.2.0-20-generic (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-------------- next part --------------
diff -Nru gnome-video-effects-0.5.0/debian/control gnome-video-effects-0.5.0/debian/control
--- gnome-video-effects-0.5.0/debian/control	2019-08-13 07:30:44.000000000 -0400
+++ gnome-video-effects-0.5.0/debian/control	2023-06-13 11:54:31.000000000 -0400
@@ -5,9 +5,8 @@
 Source: gnome-video-effects
 Section: gnome
 Priority: optional
-Maintainer: Ubuntu Developers <ubuntu-devel-discuss at lists.ubuntu.com>
-XSBC-Original-Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers at lists.alioth.debian.org>
-Uploaders: Emilio Pozuelo Monfort <pochu at debian.org>, Jeremy Bicha <jbicha at debian.org>, Laurent Bigonville <bigon at debian.org>
+Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers at lists.alioth.debian.org>
+Uploaders: Emilio Pozuelo Monfort <pochu at debian.org>, Laurent Bigonville <bigon at debian.org>
 Build-Depends: debhelper-compat (= 12),
                gnome-pkg-tools (>= 0.11),
                intltool (>= 0.40.0),
diff -Nru gnome-video-effects-0.5.0/debian/control.in gnome-video-effects-0.5.0/debian/control.in
--- gnome-video-effects-0.5.0/debian/control.in	2019-08-13 07:30:44.000000000 -0400
+++ gnome-video-effects-0.5.0/debian/control.in	2023-06-13 11:54:31.000000000 -0400
@@ -1,8 +1,7 @@
 Source: gnome-video-effects
 Section: gnome
 Priority: optional
-Maintainer: Ubuntu Developers <ubuntu-devel-discuss at lists.ubuntu.com>
-XSBC-Original-Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers at lists.alioth.debian.org>
+Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers at lists.alioth.debian.org>
 Uploaders: @GNOME_TEAM@
 Build-Depends: debhelper-compat (= 12),
                gnome-pkg-tools (>= 0.11),
diff -Nru gnome-video-effects-0.5.0/debian/patches/01-fix-for-flip-effect.patch gnome-video-effects-0.5.0/debian/patches/01-fix-for-flip-effect.patch
--- gnome-video-effects-0.5.0/debian/patches/01-fix-for-flip-effect.patch	1969-12-31 20:00:00.000000000 -0400
+++ gnome-video-effects-0.5.0/debian/patches/01-fix-for-flip-effect.patch	2023-06-13 11:54:31.000000000 -0400
@@ -0,0 +1,13 @@
+## Description: add some description
+## Origin/Author: add some origin or author
+## Bug: bug URL
+Index: gnome-video-effects-0.5.0/effects/flip.effect.desktop.in
+===================================================================
+--- gnome-video-effects-0.5.0.orig/effects/flip.effect.desktop.in
++++ gnome-video-effects-0.5.0/effects/flip.effect.desktop.in
+@@ -2,4 +2,4 @@
+ Name=Flip
+ Comment=Flip the image, as if looking at a mirror
+ Category=Geometry;
+-PipelineDescription=videoflip method=horizontal-flip
++PipelineDescription=videoflip video-direction=horiz
diff -Nru gnome-video-effects-0.5.0/debian/patches/series gnome-video-effects-0.5.0/debian/patches/series
--- gnome-video-effects-0.5.0/debian/patches/series	1969-12-31 20:00:00.000000000 -0400
+++ gnome-video-effects-0.5.0/debian/patches/series	2023-06-13 11:54:31.000000000 -0400
@@ -0,0 +1 @@
+01-fix-for-flip-effect.patch