Bug#1055324: libdmapsharing-4.0-3: tries to write to /build on end-user systems

[Simon McVittie]

Package: libdmapsharing-4.0-3
Version: 3.9.13-1
Severity: normal

Steps to reproduce: Run totem; immediately exit

Expected result: No warnings and no I/O on exit

Actual result:

> profiling:/build:Cannot create directory
> profiling:/build/reproducible-path/libdmapsharing-3.9.13/libdmapsharing/.libs/libdmapsharing_4_0_la-gst-util.gcda:Skip
> profiling:/build:Cannot create directory
> profiling:/build/reproducible-path/libdmapsharing-3.9.13/libdmapsharing/.libs/libdmapsharing_4_0_la-dmap-transcode-wav-stream.gcda:Skip

and many similar warnings.

I think this is because the check-local target in
libdmapsharing/Makefile.am rebuilds the library with
CFLAGS="-fprofile-arcs -ftest-coverage -g". This is fine for something
that is to be run by upstream, but undesirable for packaging. It would be
better if the upstream check-local target was renamed to check-coverage
or something, so that it wasn't run by `make check`.

This might also mean that optimization has been disabled.

Because test failures are ignored in debian/rules (and they do fail),
there doesn't seem to be much benefit in running them at all, so a simple
workaround would be to avoid running `make check`.

    smcv

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'stable-security'), (500, 'stable-debug'), (500, 'oldstable-security'), (500, 'oldstable-debug'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-3-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libdmapsharing-4.0-3 depends on:
ii  libavahi-client3                0.8-12
ii  libavahi-common3                0.8-12
ii  libavahi-glib1                  0.8-12
ii  libc6                           2.37-12
ii  libgdk-pixbuf-2.0-0             2.42.10+dfsg-2
ii  libglib2.0-0                    2.78.1-2
ii  libgstreamer-plugins-base1.0-0  1.22.6-1
ii  libgstreamer1.0-0               1.22.6-1
ii  libsoup-3.0-0                   3.4.4-1
ii  zlib1g                          1:1.2.13.dfsg-3

libdmapsharing-4.0-3 recommends no packages.

libdmapsharing-4.0-3 suggests no packages.

-- no debconf information