Bug#1055462: cairo: Please provide a nocheck build profile to avoid build-dep loop through poppler, rsvg, libspectre

[Samuel Thibault]

Source: cairo
Version: 1.18.0-1
Severity: normal
Tags: patch

Hello,

cairo currently build-depends on libpoppler-glib-dev, librsvg2-dev,
libspectre-dev, but conversely poppler, rsvg, and libspectre
build-depend on libcairo2-dev, thus forming a build-dependency loop
which makes bootstrapping new Debian ports tricky.

These libraries are actually used in cairo only for tests, so
introducing a nocheck build profile, as the attached patch does, gives a
way to easily break the loop, could you apply it?

Thanks,
Samuel

-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'stable-security'), (500, 'stable-debug'), (500, 'oldstable-proposed-updates-debug'), (500, 'oldstable-proposed-updates'), (500, 'oldoldstable-proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, arm64

Kernel: Linux 6.5.0-1-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.
-------------- next part --------------
--- debian/control.original	2023-11-06 11:46:12.000000000 +0000
+++ debian/control	2023-11-06 19:04:19.000000000 +0000
@@ -17,9 +17,9 @@
                liblzo2-dev,
                libpixman-1-dev,
                libpng-dev,
-               libpoppler-glib-dev,
-               librsvg2-dev,
-               libspectre-dev,
+               libpoppler-glib-dev <!nocheck>,
+               librsvg2-dev <!nocheck>,
+               libspectre-dev <!nocheck>,
                libx11-dev,
                libxcb-render0-dev,
                libxcb-shm0-dev,
--- debian/control.in.original	2023-11-06 11:47:05.000000000 +0000
+++ debian/control.in	2023-11-06 11:49:50.000000000 +0000
@@ -13,9 +13,9 @@
                liblzo2-dev,
                libpixman-1-dev,
                libpng-dev,
-               libpoppler-glib-dev,
-               librsvg2-dev,
-               libspectre-dev,
+               libpoppler-glib-dev <!nocheck>,
+               librsvg2-dev <!nocheck>,
+               libspectre-dev <!nocheck>,
                libx11-dev,
                libxcb-render0-dev,
                libxcb-shm0-dev,
--- debian/rules.original	2023-11-06 11:53:11.000000000 +0000
+++ debian/rules	2023-11-06 11:57:46.000000000 +0000
@@ -7,6 +7,11 @@
 export DEB_LDFLAGS_MAINT_APPEND = -Wl,-O1 -Wl,-z,defs
 export DPKG_GENSYMBOLS_CHECK_LEVEL = 4
 
+ifneq (,$(filter nocheck,$(DEB_BUILD_PROFILES)))
+TESTS=-Dtests=disabled \
+      -Dspectre=disabled
+endif
+
 %:
 	dh $@
 
@@ -14,7 +19,8 @@
 	-Dauto_features=enabled \
 	-Dsymbol-lookup=disabled \
 	-Dtee=enabled \
-	-Dquartz=disabled
+	-Dquartz=disabled \
+	$(TESTS)
 
 deb_configure_flags += \
 	$(configure_flags) \