Bug#1051576: bookworm-pu: package gjs/1.74.2-1+deb12u1

[Simon McVittie]

Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org at packages.debian.org
Usertags: pu
X-Debbugs-Cc: gjs at packages.debian.org
Control: affects -1 + src:gjs

[ Reason ]
#1034356

[ Impact ]
If there is a particular category of programming error (something
not disconnecting all of its signal/idle/timeout handlers when it
should, for example #1049947 which seems most likely to be a bug in
gnome-shell-extension-vertical-overview) then the failure mode is an
infinite loop of assertion messages/stack traces, flooding the log and
(in the case of GNOME Shell) freezing the UI. With the change proposed
in this update, it should instead log O(1) assertion messages and stack
traces, then continue normally, avoiding the infinite loop.

[ Tests ]
A prerelease (equivalent except for the changelog and version number) is
available in https://people.debian.org/~smcv/12.2/pool/main/g/gjs/, and I
have been using it for a couple of weeks on two bookworm GNOME machines
(a gaming desktop and my partner's laptop) with no obvious regressions.

The submitter of #1034356/#1049947 has been testing the same prerelease
for 2 weeks, but they do not know how to reproduce the bug on-demand,
so it is not immediately clear whether it has been fixed. I sent a
reminder today asking them to report their test results.

The same change has been in unstable since 17 August with no obvious
regressions, and should be released in upstream 1.78.0 soon.

[ Risks ]
I would say this is low risk: it's a targeted fix backported from
upstream, changing the order of some operations so that on a programming
error, callbacks reliably return a zero-filled value (usually 0 or NULL)
instead of whatever happens to be in uninitialized memory.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]
All changes are for #1034356.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gjs_1.74.2-1+deb12u1.diff
Type: text/x-diff
Size: 6843 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-gnome-maintainers/attachments/20230909/f7bdfedf/attachment.diff>