Bug#1052229: bookworm-pu (pre-approval): gnome-shell/43.9-0+deb12u1

Tue Sep 19 11:40:48 BST 2023

Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org at packages.debian.org
Usertags: pu
X-Debbugs-Cc: gnome-shell at packages.debian.org, debian-gtk-gnome at lists.debian.org
Control: affects -1 + src:gnome-shell

[ Reason ]
Several new upstream bugfix releases. I've been trying to get these into
a suitable state for a stable update since 12.1, but every time I've
been testing one long enough to think about asking for upload approval,
there have been more bugfixes upstream and the cycle starts again.

This is probably going to be the last upstream release in the 43.x series,
although we might get a 43.10.

[ Impact ]
Various fixes for crashes and other bugs. This also converts the fix
for CVE-2023-43090 (which was fixed via a DSA) from a patch to part of
the upstream source.

[ Tests ]
A prerelease build differing only in changelog and version is available at
https://people.debian.org/~smcv/12.3/pool/main/g/gnome-shell/
and is in use on my household's bookworm laptop/desktop systems, with
no obvious regressions seen immediately (but I only installed it recently).
The diff is not small and the 12.2 deadline is coming up, so I think we
should continue testing this until after 12.2 is out, and then upload. I
would appreciate any testing that the rest of the GNOME team can provide.

43.7-1 was in testing for a while, and 43.7-2 was briefly in unstable
before it was superseded by version 44. I also tested bookworm backports
of 43.7-2 and 43.8 on my household's bookworm laptop/desktop systems for
a while.

I confirmed that CVE-2023-43090 is not reproducible in this version.
I generally haven't specifically attempted to reproduce other bugs.

[ Risks ]
I am not any sort of expert on compositor development, but upstream
have generally been good about backporting only bug fixes to their
stable branches. There have been some regressions in the past because
this stuff is difficult. If there are regressions from these changes,
they're likely to be of the same magnitude as the bugs that were fixed.

The changes in subprojects/gvc/ are a larger diffstat than I would like
(including performance improvements as well as bug fixes), but also
relatively straightforward if we look closely.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
      - the diff given here is between patched trees, using the fix for
        CVE-2023-43090 in bookworm-security as its reference point, and
        is lightly filtered to avoid wasting the release team's time
        (see top of diff for the exact filterdiff command)
  [x] the issue is verified as fixed in unstable

[ Changes ]

js/misc/ibusManager.js:
    - Add missing environment variables required to launch ibus-daemon
      (gnome-shell#6998, fixed in 44.5 for unstable)
    - Report focus events to ibus when using Wayland (gnome-shell#6415)
      and fix a regression caused by the initial version of that change
      (both changes were in 44.4 for unstable)

js/misc/inputMethod.js:
    - Better compatibility with Debian 12's version of ibus
      (gnome-shell#6405, fixed in 44.4 for unstable)

js/misc/parentalControlsManager.js:
    - Don't log an error when AccountsService signals a change while
      parental controls are disabled globally
      (gnome-shell#6749, fixed in 44.3 for unstable)

js/misc/weather.js:
    - When showing weather, avoid getting meaningless location names like
      "WiFi" or "GeoIP" from GeoClue >= 2.7 (fixed in 44.4 for unstable)

js/ui/barLevel.js, js/ui/slider.js:
    - Reverse the direction of volume/brightness sliders in right-to-left
      locales (Arabic, Hebrew) to match user expectations
      (fixed in 44.5 for unstable)

js/ui/keyboard.js:
    - When using the on-screen keyboard in numeric mode, don't go back to
      alphabetical mode after each keypress
      (gnome-shell#5763, fixed in 44.5 for unstable)

js/ui/lookingGlass.js:
    - In the "looking glass" debug interface, cope with objects that
      cannot be converted to string (fixed in 44.4 for unstable)

js/ui/magnifier.js:
    - Apply hotspot translation to mouse cursor while using magnifier,
      fixing an offset between the visble pointer position and the actual
      pointer (gnome-shell#4584, fixed in 44.3 for unstable)

js/ui/messageList.js:
    - Allow notifications to be dismissed with backspace key in addition to
      delete key, for easier use on laptops where the delete key might be
      missing or hard to reach (gnome-shell#5789, fixed in 44.4 for unstable)

js/ui/quickSettings.js:
    - Avoid sliders in quick settings (volume, etc.) being reported to
      accessibility tools as their own parent object (gnome-shell#6686,
      fixed in 44.4 for unstable)

js/ui/workspace.js:
    - Keep rounded corners on the overview's view of the desktop, even
      after the background image changes
      (gnome-shell#4125, fixed in 44.3 for unstable)

po/POTFILES.in:
- Make an extra file translatable (fixed in 44.4 in unstable)

po/POTFILES.skip:
- Skip translations for a file that isn't user-visible

po/*.po: Translation updates

src/st-viewport.c:
    - Improve GNOME Shell app grid performance by avoiding repainting
      monitors other than the one it is displayed on (gnome-shell#6819,
      fixed in 44.4 for unstable)
      - this change is only fully effective when combined with mutter 43.8
    - Align scrolled viewports to the pixel grid to avoid jitter visible
      during scrolling (gnome-shell#6835, fixed in 44.4 for unstable)

src/main.c:
    Skip final cleanup during exit.
    This has been implicated in various crashes during exit, which cause
    gnome-shell to disable extensions during the next startup. Leaking some
    memory at this point does not matter since the process is exiting anyway.
    The crashes during exit are believed to have been fixed in 44.beta, but
    those changes are too intrusive to be suitable for a backport.
    (Closes: #1038972, not needed in unstable since 44.beta)

subprojects/gvc/:
    - Update subprojects/gvc subproject to the same version used in sid
      (gnome-shell#6842, same change is in 44.4 in unstable)
      + Fix duplicate devices shown when reconnecting to PulseAudio
      + Fix possible use-after-free crashes on PulseAudio/Pipewire restart
      + Improve choice of default icons
      + Performance improvements

.gitlab-ci/: Upstream CI changes, filtered out of the diff

[ Other info ]
I've only tested this in conjunction with an accompanying mutter update,
and it would be useful for a release team member to coordinate processing
of the two updates.

For my reference, the attached diff corresponds to packaging
commit 80171eefd, and the matching prerelease builds are versioned as
43.9-0+deb12u1~43.7+2+48+g80171eefd.

    smcv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gnome-shell_43.9-0+deb12u1~43.7+2+48+g80171eefd.diff
Type: text/x-diff
Size: 91760 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-gnome-maintainers/attachments/20230919/956dd0d2/attachment-0001.diff>