Bug#1075540: startup-notification: ftbfs with GCC-14

[Matthias Klose]

Package: src:startup-notification
Version: 0.12-6
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/startup-notification_0.12-6_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
test-send-xmessage.c:60:39: error: passing argument 3 of ‘sn_internal_broadcast_xmessage’ makes integer from pointer without a cast [-Wint-conversion]
   60 |                                   argv[1],
      |                                   ~~~~^~~
      |                                       |
      |                                       char *
In file included from test-send-xmessage.c:27:
../libsn/sn-xmessages.h:51:56: note: expected ‘xcb_atom_t’ {aka ‘unsigned int’} but argument is of type ‘char *’
   51 |                                        xcb_atom_t      message_type,
      |                                        ~~~~~~~~~~~~~~~~^~~~~~~~~~~~
test-send-xmessage-xcb.c:55:39: error: passing argument 3 of ‘sn_internal_broadcast_xmessage’ makes integer from pointer without a cast [-Wint-conversion]
   55 |                                   argv[1],
      |                                   ~~~~^~~
      |                                       |
      |                                       char *
In file included from test-send-xmessage-xcb.c:28:
../libsn/sn-xmessages.h:51:56: note: expected ‘xcb_atom_t’ {aka ‘unsigned int’} but argument is of type ‘char *’
   51 |                                        xcb_atom_t      message_type,
      |                                        ~~~~~~~~~~~~~~~~^~~~~~~~~~~~
test-send-xmessage.c:61:39: error: passing argument 4 of ‘sn_internal_broadcast_xmessage’ makes integer from pointer without a cast [-Wint-conversion]
   61 |                                   argv[2],
      |                                   ~~~~^~~
      |                                       |
      |                                       char *
../libsn/sn-xmessages.h:52:56: note: expected ‘xcb_atom_t’ {aka ‘unsigned int’} but argument is of type ‘char *’
   52 |                                        xcb_atom_t      message_type_begin,
      |                                        ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
test-send-xmessage-xcb.c:56:39: error: passing argument 4 of ‘sn_internal_broadcast_xmessage’ makes integer from pointer without a cast [-Wint-conversion]
   56 |                                   argv[2],
      |                                   ~~~~^~~
      |                                       |
      |                                       char *
../libsn/sn-xmessages.h:52:56: note: expected ‘xcb_atom_t’ {aka ‘unsigned int’} but argument is of type ‘char *’
   52 |                                        xcb_atom_t      message_type_begin,
      |                                        ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
In file included from test-send-xmessage-xcb.c:30:
test-boilerplate.h: At top level:
test-boilerplate.h:111:1: warning: ‘error_trap_pop’ defined but not used [-Wunused-function]
  111 | error_trap_pop (SnDisplay *display,
      | ^~~~~~~~~~~~~~
test-boilerplate.h:104:1: warning: ‘error_trap_push’ defined but not used [-Wunused-function]
  104 | error_trap_push (SnDisplay *display,
      | ^~~~~~~~~~~~~~~
test-boilerplate.h:79:1: warning: ‘x_error_handler’ defined but not used [-Wunused-function]
   79 | x_error_handler (Display     *xdisplay,
      | ^~~~~~~~~~~~~~~
make[3]: *** [Makefile:522: test-send-xmessage.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: *** [Makefile:522: test-send-xmessage-xcb.o] Error 1
test-launcher.c: In function ‘slowly_obtain_timestamp’:
test-launcher.c:69:42: warning: pointer targets in passing argument 7 of ‘XChangeProperty’ differ in signedness [-Wpointer-sign]
   69 |                      8, PropModeReplace, name, strlen (name));
      |                                          ^~~~
      |                                          |
      |                                          char *
In file included from /usr/include/X11/Xlib.h:47,
                 from ../libsn/sn-common.h:30,
                 from ../libsn/sn-launchee.h:30,
                 from ../libsn/sn.h:30,
                 from test-launcher.c:26:
/usr/include/X11/Xlib.h:2089:5: note: expected ‘const unsigned char *’ but argument is of type ‘char *’
 2089 |     _Xconst unsigned char*      /* data */,
      |     ^
make[3]: Leaving directory '/<<PKGBUILDDIR>>/test'
make[2]: *** [Makefile:629: check-am] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/test'
make[1]: *** [Makefile:472: check-recursive] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_test: error: make -j8 check "TESTSUITEFLAGS=-j8 --verbose" VERBOSE=1 returned exit code 2
make: *** [debian/rules:7: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2