Bug#1075622: vinagre: ftbfs with GCC-14

[Matthias Klose]

Package: src:vinagre
Version: 3.22.0-8.1
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/vinagre_3.22.0-8.1_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
  794 |   vnc_tab->priv->align = gtk_alignment_new (0.5, 0.5, 1, 1);
      |   ^~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:255:
/usr/include/gtk-3.0/gtk/deprecated/gtkalignment.h:79:12: note: declared here
   79 | GtkWidget* gtk_alignment_new        (gfloat             xalign,
      |            ^~~~~~~~~~~~~~~~~
plugins/vnc/vinagre-vnc-tab.c: In function ‘vinagre_vnc_tab_set_scaling’:
plugins/vnc/vinagre-vnc-tab.c:926:3: warning: ‘gtk_action_set_sensitive’ is deprecated [-Wdeprecated-declarations]
  926 |   gtk_action_set_sensitive (tab->priv->keep_ratio_action, active);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gtk/deprecated/gtkaction.h:109:14: note: declared here
  109 | void         gtk_action_set_sensitive          (GtkAction     *action,
      |              ^~~~~~~~~~~~~~~~~~~~~~~~
plugins/vnc/vinagre-vnc-tab.c: In function ‘vinagre_vnc_tab_set_viewonly’:
plugins/vnc/vinagre-vnc-tab.c:953:5: warning: ‘gtk_action_set_sensitive’ is deprecated [-Wdeprecated-declarations]
  953 |     gtk_action_set_sensitive (tab->priv->ctrlaltdel_action, !active);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gtk/deprecated/gtkaction.h:109:14: note: declared here
  109 | void         gtk_action_set_sensitive          (GtkAction     *action,
      |              ^~~~~~~~~~~~~~~~~~~~~~~~
vinagre/vinagre-utils.c: In function ‘vinagre_utils_show_many_errors’:
vinagre/vinagre-utils.c:243:34: error: passing argument 2 of ‘g_slist_foreach’ from incompatible pointer type [-Wincompatible-pointer-types]
  243 |         g_slist_foreach (_tmp1_, ___lambda5__gfunc, _data2_);
      |                                  ^~~~~~~~~~~~~~~~~
      |                                  |
      |                                  void (*)(const void *, void *)
In file included from /usr/include/glib-2.0/glib/gmain.h:28,
                 from /usr/include/glib-2.0/glib/giochannel.h:35,
                 from /usr/include/glib-2.0/glib.h:56,
                 from vinagre/vinagre-utils.c:22:
/usr/include/glib-2.0/glib/gslist.h:128:61: note: expected ‘GFunc’ {aka ‘void (*)(void *, void *)’} but argument is of type ‘void (*)(const void *, void *)’
  128 |                                           GFunc             func,
      |                                           ~~~~~~~~~~~~~~~~~~^~~~
vinagre/vinagre-utils.c: In function ‘vinagre_utils_request_credential’:
vinagre/vinagre-utils.c:717:9: warning: ‘gtk_image_new_from_stock’ is deprecated: Use 'gtk_image_new_from_icon_name' instead [-Wdeprecated-declarations]
  717 |         _tmp34_ = (GtkImage*) gtk_image_new_from_stock (GTK_STOCK_DIALOG_AUTHENTICATION, GTK_ICON_SIZE_BUTTON);
      |         ^~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtkentry.h:42,
                 from /usr/include/gtk-3.0/gtk/gtktreeview.h:29,
                 from /usr/include/gtk-3.0/gtk/gtkcombobox.h:27,
                 from /usr/include/gtk-3.0/gtk/gtkappchooserbutton.h:29,
                 from /usr/include/gtk-3.0/gtk/gtk.h:42,
                 from vinagre/vinagre-utils.c:26:
/usr/include/gtk-3.0/gtk/gtkimage.h:122:12: note: declared here
  122 | GtkWidget* gtk_image_new_from_stock     (const gchar     *stock_id,
      |            ^~~~~~~~~~~~~~~~~~~~~~~~
vinagre/vinagre-utils.c:717:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
  717 |         _tmp34_ = (GtkImage*) gtk_image_new_from_stock (GTK_STOCK_DIALOG_AUTHENTICATION, GTK_ICON_SIZE_BUTTON);
      |         ^~~~~~~
vinagre/vinagre-utils.c: In function ‘vinagre_utils_show_help’:
vinagre/vinagre-utils.c:928:17: warning: ‘gtk_show_uri’ is deprecated: Use 'gtk_show_uri_on_window' instead [-Wdeprecated-declarations]
  928 |                 gtk_show_uri (_tmp5_, _tmp6_, (guint32) GDK_CURRENT_TIME, &_inner_error_);
      |                 ^~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:200:
/usr/include/gtk-3.0/gtk/gtkshow.h:33:10: note: declared here
   33 | gboolean gtk_show_uri  (GdkScreen   *screen,
      |          ^~~~~~~~~~~~
vinagre/vinagre-utils.c: At top level:
vinagre/vinagre-utils.c:194:20: warning: ‘block2_data_ref’ defined but not used [-Wunused-function]
  194 | static Block2Data* block2_data_ref (Block2Data* _data2_) {
      |                    ^~~~~~~~~~~~~~~
make[3]: *** [Makefile:1609: vinagre/vinagre-vinagre-utils.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: *** [Makefile:2214: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:850: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:7: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2