Bug#1067102: librsvg: please make the build reproducible

[Chris Lamb]

Source: librsvg
Version: 2.57.92+dfsg-2
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: umask
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
librsvg could not be built reproducibly due to a typo in debian/rules:

        # debhelper >= 13.4 makes all of /usr/libexec executable, which is not
        # quite right for installed-tests
        override_dh_fixperms:
                dh_fixperms -Xusr/libexec/rsvg/tests
        ifneq ($(filter %-tests,$(binaries)),)
                chmod --recursive --changes a+rX,u+w,og-w debian/*-tests/usr/libexec/rsvg/tests
        endif

This should refer to "$(built_binaries)", not "$(binaries)"… and so
the line is not run... resulting in the build varying depending on the
build system's umask. :)

A patch that corrects this typo is attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-


-------------- next part --------------
--- a/debian/rules	2024-03-18 12:02:58.659721987 +0000
--- b/debian/rules	2024-03-18 12:57:15.974155554 +0000
@@ -52,7 +52,7 @@
 # quite right for installed-tests
 override_dh_fixperms:
 	dh_fixperms -Xusr/libexec/rsvg/tests
-ifneq ($(filter %-tests,$(binaries)),)
+ifneq ($(filter %-tests,$(built_binaries)),)
 	chmod --recursive --changes a+rX,u+w,og-w debian/*-tests/usr/libexec/rsvg/tests
 endif