Bug#1060803: marked as pending in gnome-software

[Alban Browaeys]

Dear Maintainer,

I believe you misunderstood the reported issue in
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1060803
ie you dropped the patch for to support software-properties-gtk but
left the dependency on it, while the request was to move the dependency
from a depend to a recommand but keep the patch (ie the patch trigger
the gnome software UI if gnome-software-properties-gtk is not installed
as requested by the bug reporter).

gnome-software-properies is still a dependency
but never called even if installed:
"Drop patch that hides upstreams Software Sources dialog"
https://salsa.debian.org/gnome-team/gnome-software/-/commit/1718e18bf93df01666fe3ee06aef09f674675bfb

To me the opposite was asked for:
> > > Fair point. We could maybe make it so g-s-p is only a recommended
> > > dependency
> > 
> > That is what this request is requesting. Just a change from depend
> to
> > recommend
> > 
> > > and modify the code so when g-s-p is not available, it
> > > falls back to the GS dialog.
> > 
> > I'm not sure what code you're referring to, but when running GNOME
> > Software on Debian without s-p-gtk installed, the GS dialog is
> instead
> > used.
> 
> Neat, looks like I wrote it properly back then :-)
> Also appears like the change was reverted upstream a few months ago,
> I
> wonder why... (we patch it back in at Debian/Ubuntu anyway)
> 
> In any case, I have no objections to moving g-s-p to recommends under
> these circumstances :-)


Cheers,
Alban

On Wed, 27 Mar 2024 13:07:46 +0000 Jeremy Bicha
<noreply at salsa.debian.org> wrote:
> Control: tag -1 pending
> 
> Hello,
> 
> Bug #1060803 in gnome-software reported by you has been fixed in the
> Git repository and is awaiting an upload. You can see the commit
> message below and you can check the diff of the fix at:
> 
> 
https://salsa.debian.org/gnome-team/gnome-software/-/commit/1718e18bf93df01666fe3ee06aef09f674675bfb
> 
> ---------------------------------------------------------------------
---
> Drop patch that hides upstreams Software Sources dialog
> 
> Closes: #1060803
> ---------------------------------------------------------------------
---
> 
> (this message was generated automatically)
> -- 
> Greetings
> 
> https://bugs.debian.org/1060803
> 
>