Bug#1059000: mutter : Please add support for loong64

[Simon McVittie]

On Fri, 06 Sep 2024 at 20:20:24 +0800, zhangdandan wrote:
> > On Mon, Sep 2, 2024 at 5:12 AM zhangdandan wrote:
> > > Now, there are still 2 failing tests.
> > > ```
> > > 182/185 mutter:core+mutter/x11 / x11 FAIL 10.27s (exit status 133 or signal
> 5 SIGTRAP)
> > > 183/185 mutter:core+mutter/x11 / x11-sync FAIL 10.27s (exit status 133 or
> signal 5 SIGTRAP)

Please look into the test log and find out why these tests are failing /
what messages they are producing.

As I think I said before, the purpose of tests is to find problems *before*
your users have to experience them on production systems. Before ignoring
a failing test, someone should have assessed the impact of whatever feature
or part of the package is broken.

Whatever the reason for an architecture-specific failure is, there should
be a bug reported for it, with appropriate usertags.

If the failure is a problem with the new ORCJIT llvmpipe driver that is
now used on loong64, a possible workaround is to run the tests with
GALLIUM_DRIVER=softpipe in the environment, like we do for mips* in the
gtk4 source package.

> Please consider add loong64 in mutter source package's d/rules.
> ```
> # Please keep this list in sync with debian/tests/installed-tests
> override_dh_auto_test:
> -ifeq (,$(filter mips64el riscv64 s390x,$(DEB_HOST_ARCH)))
> +ifeq (,$(filter mips64el riscv64 s390x loong64,$(DEB_HOST_ARCH)))
>         $(TEST_COMMAND)
>         -$(TEST_COMMAND_FLAKY) --logbase flaky-tests

Instead of disabling the entire test suite, if a subset of tests are
known-broken on loong64 and they do not indicate a serious problem with
mutter, I would prefer to ignore only those tests.

For x11 and x11-sync, the easiest way to do this would be to mark them
as flaky in src/tests/meson.build, something like this:

--------------------------------------------------------
extra_suites = []

if host_machine.cpu_family() == 'loongarch64'
  # https://bugs.debian.org/xxxxxx
  extra_suites += ['flaky']
endif

test(...,
  suite: ['core', 'mutter/x11'] + extra_suites,
  ...
  )
--------------------------------------------------------

replacing https://bugs.debian.org/xxxxxx with the bug that you reported.

    smcv