Bug#1081179: Example patch hunk from a commit message applied to package source

[Simon Tatham]

Source: gtk+3.0
Version: 3.24.43-3

When I download the gtk+3.0 source package via 'apt source' on Debian
sid, I find that the source file demos/gtk-demo/dialog.c contains this
statement in message_dialog_clicked():

  gtk_window_set_title (GTK_WINDOW (dialog), "Some informative title");

This statement isn't in the upstream package. It has appeared in the
Debian source as a result of applying the patch in
debian/patches/a11y-Use-non-empty-message-dialog-title-as-a11y-name.patch

But if you look at that patch, it's in 'git format-patch' format,
containing a few headers, a commit message, and then the actual patch.
And the patch hunk that introduced "Some informative title" is part of
the _commit message_: it's clear from the surrounding text that the
commit message author intended it as an example of the kind of change
you _could_ apply if you wanted to test the behaviour modified by the
patch. The author even indented the entire patch hunk by 4 spaces to
indicate extra clearly that it wasn't intended to be applied.

So it surely should _not_ have been applied to the Debian source!

(I suppose this could very well be viewed as a bug in whatever thing
underlying 'apt source' is applying the patches, but I don't know enough
about that part of Debian to be reliably able to report the bug in the
right place.)

Cheers,
Simon

-- 
for k in [pow(x,37,0x1a1298d262b49c895d47f) for x in [0x50deb914257022de7fff,
0x213558f2215127d5a2d1, 0x90c99e86d08b91218630, 0x109f3d0cfbf640c0beee7,
0xc83e01379a5fbec5fdd1, 0x19d3d70a8d567e388600e, 0x534e2f6e8a4a33155123]]:
 print("".join([chr(32+3*((k>>x)&1))for x in range(79)])) # <anakin at pobox.com>