Bug#1057562: gcr4: FTBFS: failing tests

[Santiago Vila]

tags 1057562 patch
thanks

Jeremy Bícha wrote:
> I am willing to accept a patch to disable that subtest.

Ok, please consider the attached patch (which I have actually tested).

I've tried to be neutral in the explanation without being too much specific.
In particular, the test does not only fail on machines with only one CPU.
I already noted that here:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1057562#96

Thanks.
-------------- next part --------------
diff -Nru gcr4-4.4.0.1/debian/changelog gcr4-4.4.0.1/debian/changelog
--- gcr4-4.4.0.1/debian/changelog	2025-03-21 22:31:31.000000000 +0100
+++ gcr4-4.4.0.1/debian/changelog	2025-04-09 15:55:00.000000000 +0200
@@ -1,3 +1,10 @@
+gcr4 (4.4.0.1-3) unstable; urgency=medium
+
+  * Disable test which segfaults on some systems for reasons still unknown.
+    Closes: #1057562.
+
+ -- Jeremy Bícha <jbicha at ubuntu.com>  Wed, 09 Apr 2025 15:55:00 +0200
+
 gcr4 (4.4.0.1-2) unstable; urgency=medium
 
   * Opt into Salsa CI
diff -Nru gcr4-4.4.0.1/debian/patches/disable-test-which-segfaults.patch gcr4-4.4.0.1/debian/patches/disable-test-which-segfaults.patch
--- gcr4-4.4.0.1/debian/patches/disable-test-which-segfaults.patch	1970-01-01 01:00:00.000000000 +0100
+++ gcr4-4.4.0.1/debian/patches/disable-test-which-segfaults.patch	2025-04-09 15:55:00.000000000 +0200
@@ -0,0 +1,24 @@
+Description: Disable test which segfaults on some systems
+Author: Santiago Vila <sanvila at debian.org>
+Bug-Debian: https://bugs.debian.org/1057562
+Forwarded: https://gitlab.gnome.org/GNOME/gcr/-/issues/119
+Last-Update: 2025-04-09
+
+On some systems, the test below aborts with segfault, like this:
+
+18/43 gcr:gck / object             FAIL            0.02s   killed by signal 11 SIGSEGV
+
+This apparently happens on single-CPU systems with very high probability, but it
+has been also observed on machines with 2 CPUs.
+
+--- a/gck/test-gck-object.c
++++ b/gck/test-gck-object.c
+@@ -420,7 +420,7 @@
+ 	g_test_add ("/gck/object/destroy_object", Test, NULL, setup, test_destroy_object, teardown);
+ 	g_test_add ("/gck/object/get_attributes", Test, NULL, setup, test_get_attributes, teardown);
+ 	g_test_add ("/gck/object/get_data_attribute", Test, NULL, setup, test_get_data_attribute, teardown);
+-	g_test_add ("/gck/object/set_attributes", Test, NULL, setup, test_set_attributes, teardown);
++	/* g_test_add ("/gck/object/set_attributes", Test, NULL, setup, test_set_attributes, teardown); */
+ 	g_test_add ("/gck/object/find_objects", Test, NULL, setup, test_find_objects, teardown);
+ 
+ 	return egg_tests_run_with_loop ();
diff -Nru gcr4-4.4.0.1/debian/patches/series gcr4-4.4.0.1/debian/patches/series
--- gcr4-4.4.0.1/debian/patches/series	2025-03-21 22:31:31.000000000 +0100
+++ gcr4-4.4.0.1/debian/patches/series	2025-04-09 15:55:00.000000000 +0200
@@ -1 +1,2 @@
 systemd-Start-with-graphical-session-instead-of-default.patch
+disable-test-which-segfaults.patch