Bug#1093082: wsdd: TimeoutError logged in syslog when run from gvfsd

[Simon McVittie]

Control: retitle -1 wsdd: TimeoutError logged in syslog when run from gvfsd
Control: reassign -1 wsdd
Control: affects -1 + gvfs-daemons

On Wed, 15 Jan 2025 at 08:07:54 +0100, Francesco Potortì wrote:
>  gvfsd[2245675]:   File "/usr/bin/wsdd", line 330, in read_socket
>  gvfsd[2245675]:     handler.handle_packet(msg.decode('utf-8'), address)

This is actually coming from wsdd (which is a Recommends for the
gvfs-backends package), and not from gvfs-daemons or gvfs-backends
themselves.

If wsdd is communicating with an arbitrary devices on your LAN compatible
with the Windows Service Discovery Protocol, and one of them stops
responding part way through a request, then it's probably
expected/intentional that wsdd logs a message about that; but ideally it
would be something shorter like "wsdd: timeout while communicating with
192.168.5.250" rather than a full traceback.

(Full text of the log message quoted below for the wsdd maintainers)

    smcv

>  gvfsd[2245675]: 2025-01-14 14:14:32,531:asyncio ERROR(pid 2245675): Exception in callback MulticastHandler.read_socket(<socket.socke...5.250', 3702)>)
>  gvfsd[2245675]: handle: <Handle MulticastHandler.read_socket(<socket.socke...5.250', 3702)>)>
>  gvfsd[2245675]: Traceback (most recent call last):
>  gvfsd[2245675]:   File "/usr/lib/python3.12/asyncio/events.py", line 88, in _run
>  gvfsd[2245675]:     self._context.run(self._callback, *self._args)
>  gvfsd[2245675]:   File "/usr/bin/wsdd", line 330, in read_socket
>  gvfsd[2245675]:     handler.handle_packet(msg.decode('utf-8'), address)
>  gvfsd[2245675]:   File "/usr/bin/wsdd", line 742, in handle_packet
>  gvfsd[2245675]:     self.handle_message(msg, src)
>  gvfsd[2245675]:   File "/usr/bin/wsdd", line 534, in handle_message
>  gvfsd[2245675]:     retval = handler(header, body)
>  gvfsd[2245675]:              ^^^^^^^^^^^^^^^^^^^^^
>  gvfsd[2245675]:   File "/usr/bin/wsdd", line 769, in handle_hello
>  gvfsd[2245675]:     self.perform_metadata_exchange(endpoint, xaddr)
>  gvfsd[2245675]:   File "/usr/bin/wsdd", line 856, in perform_metadata_exchange
>  gvfsd[2245675]:     with urllib.request.urlopen(request, None, args.metadata_timeout) as stream:
>  gvfsd[2245675]:          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  gvfsd[2245675]:   File "/usr/lib/python3.12/urllib/request.py", line 215, in urlopen
>  gvfsd[2245675]:     return opener.open(url, data, timeout)
>  gvfsd[2245675]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  gvfsd[2245675]:   File "/usr/lib/python3.12/urllib/request.py", line 515, in open
>  gvfsd[2245675]:     response = self._open(req, data)
>  gvfsd[2245675]:                ^^^^^^^^^^^^^^^^^^^^^
>  gvfsd[2245675]:   File "/usr/lib/python3.12/urllib/request.py", line 532, in _open
>  gvfsd[2245675]:     result = self._call_chain(self.handle_open, protocol, protocol +
>  gvfsd[2245675]:              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  gvfsd[2245675]:   File "/usr/lib/python3.12/urllib/request.py", line 492, in _call_chain
>  gvfsd[2245675]:     result = func(*args)
>  gvfsd[2245675]:              ^^^^^^^^^^^
>  gvfsd[2245675]:   File "/usr/lib/python3.12/urllib/request.py", line 1373, in http_open
>  gvfsd[2245675]:     return self.do_open(http.client.HTTPConnection, req)
>  gvfsd[2245675]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  gvfsd[2245675]:   File "/usr/lib/python3.12/urllib/request.py", line 1348, in do_open
>  gvfsd[2245675]:     r = h.getresponse()
>  gvfsd[2245675]:         ^^^^^^^^^^^^^^^
>  gvfsd[2245675]:   File "/usr/lib/python3.12/http/client.py", line 1428, in getresponse
>  gvfsd[2245675]:     response.begin()
>  gvfsd[2245675]:   File "/usr/lib/python3.12/http/client.py", line 331, in begin
>  gvfsd[2245675]:     version, status, reason = self._read_status()
>  gvfsd[2245675]:                               ^^^^^^^^^^^^^^^^^^^
>  gvfsd[2245675]:   File "/usr/lib/python3.12/http/client.py", line 292, in _read_status
>  gvfsd[2245675]:     line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
>  gvfsd[2245675]:                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  gvfsd[2245675]:   File "/usr/lib/python3.12/socket.py", line 720, in readinto
>  gvfsd[2245675]:     return self._sock.recv_into(b)
>  gvfsd[2245675]:            ^^^^^^^^^^^^^^^^^^^^^^^
>  gvfsd[2245675]: TimeoutError: timed out