Bug#1109382: evince: FTBFS if appstream is installed due to syntax error in Hindi translation

[Simon McVittie]

Source: evince
Version: 48.0-1
Severity: normal
Tags: ftbfs upstream fixed-upstream
Justification: FTBFS but only in a way that does not affect buildds
Forwarded: https://gitlab.gnome.org/Infrastructure/damned-lies/-/issues/655
Control: close -1 48.1-1

There is a syntax error in the Hindi translation for evince, fixed by 
commit d860534326eae81d8282e3b0196cb63df07bb800 upstream. This results 
in a build-time test failure if building in a non-minimal environment 
where the appstream package is installed, for example with:

    sbuild --add-depends=appstream

> ==================================== 1/1 =====================================
> test:         validate-appdata
> start time:   10:24:11
> duration:     0.02s
> result:       exit status 3
> command:      MALLOC_PERTURB_=240 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MESON_TEST_ITERATION=1 /usr/bin/appstreamcli validate --no-net --explain org.gnome.Evince.metainfo.xml
> ----------------------------------- stdout -----------------------------------
> W: org.gnome.Evince:283: tag-empty p
>    The mentioned tag is empty, which is highly likely not intended as it should have content.
> 
> I: org.gnome.Evince:434: developer-name-tag-deprecated
>    The toplevel `developer_name` element is deprecated. Please use the `name` element in a
>    `developer` block instead.
> 
> I: org.gnome.Evince:533: nonstandard-gnome-extension kudos
>    This tag is a GNOME-specific extension to AppStream and not part of the official specification.
>    Do not expect it to work in all implementations and in all software centers.
> 
> ✘ Validation failed: warnings: 1, infos: 2, pedantic: 1
> ==============================================================================
> 
> 
> Summary of Failures:
> 
> 1/1 validate-appdata FAIL            0.02s   exit status 3

This does not affect minimal build environments like the official 
buildds, so I am not reporting this as a release-critical bug. It was 
fixed upstream after 48.1, and I included the fix in 48.1-1.

When debugging 48.0-1 interactively on a non-minimal system (as I am 
doing now for #1109381), a workaround is to apply 
d/p/po-Fix-xml-element-in-Hindi-translation.patch as found in 48.1-1.

    smcv