Bug#1109432: unblock: evince/48.1-2

[Simon McVittie]

Package: release.debian.org
Severity: normal
X-Debbugs-Cc: evince at packages.debian.org
Control: affects -1 + src:evince
User: release.debian.org at packages.debian.org
Usertags: unblock

[ Reason ]

- New upstream bugfix release
- Fix a high-visibility bug in presentation mode found while testing the
  new release (it is not a regression, trixie has the bug too)

[ Impact ]

Several bug fixes. Probably the highest-impact is that presentation mode 
had incorrect scaling on HighDPI devices, due to a now-redundant 
workaround for a GTK bug that was subsequently fixed (#1093497).

While verifying the fix for #1093497 I found #1109381, a high-visibility 
issue with presentation mode: swapping from normal view to presentation 
mode often leaves an unresponsive copy of the menu "stuck" on the 
screen", which would be an embarrassingly visible display issue if I was 
actually giving a presentation.

[ Tests ]

Manually tested with some simple PDF files. I can reproduce #1093497 
with trixie's evince on a device where GNOME defaults to 2x pixel ratio 
(Lenovo X1 Carbon, 5th gen) and it is fixed in the proposed version.

[ Risks ]

Key package, default document viewer for our default desktop environment 
(it is likely to be replaced with Papers in forky, but that came too 
late for trixie).

I am not a primary maintainer of this package, I'm only filling in for 
other team members who have less time available.

The changes that check for integer overflow in memory allocation sizes 
are actually entirely redundant because g_new0() does an equivalent 
check. I discussed this with upstream and we agree the change is 
harmless; they are probably going to revert it, but it isn't seen as 
urgent to do so.

All other changes are targeted and seem proportionate to the problems that 
they fix. The package builds shared libraries, but not many other 
packages use them (only denemo, gnome-sushi and phosh-plugins) and the 
changes that touch library code in libdocument/ and libview/ are 
particularly narrowly-targeted.

The fix for #1109381 comes from an upstream maintainer, but has not been 
reviewed or merged, and seems more like a workaround than a real 
solution; unfortunately I don't understand the root cause. It does help 
a lot, though. In my testing, the change fully fixes presentation mode, 
but does not fully fix fullscreen mode, only making the symptom less 
likely there. However, in fullscreen mode it can be addressed by 
reopening and closing the menu.

[ Checklist ]

  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing
      (filtered to exclude translations and patches; the actual changes
      made by the patches are present in the diff)

unblock evince/48.1-2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: evince_48.1-2.diff
Type: text/x-diff
Size: 18743 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-gnome-maintainers/attachments/20250717/b6d3325e/attachment-0001.diff>