[Pkg-gnupg-maint] Bug#521884: gnupg: reversed logic of the nocheck test in debian/rules

[Neil Williams]

Package: gnupg
Version: 1.4.9-4
Severity: normal

This test in debian/rules has reversed the logic of the test:

ifneq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
    make -C build-deb/checks check || exit 1
endif

It should be:

ifeq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
    make -C build-deb/checks check || exit 1
endif

i.e. if findstring cannot find nocheck in DEB_BUILD_OPTIONS, it passes '' which matches
the empty string before the comma, therefore, the checks are performed.

http://wiki.debian.org/EmdebianGuide#DEBBUILDOPTIONS

This results in the tests not actually being run - despite the appearance of some tests
in the buildd log, the actual make check produces a different output.

The buildd log should include:

make[2]: Entering directory `/home/gnupg-1.4.9/build-deb/checks'
gpg (GnuPG) 1.4.9
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Home: .
Supported algorithms:
Pubkey: RSA, RSA-E, RSA-S, ELG-E, DSA
Cipher: 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH
Hash: MD5, SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224
Compression: Uncompressed, ZIP, ZLIB, BZIP2
PASS: version.test
PASS: mds.test
PASS: decrypt.test
PASS: decrypt-dsa.test
MD5 SHA1 RIPEMD160 SHA256 SHA384 SHA512 SHA224 | PASS: sigs.test
PASS: sigs-dsa.test
3DES CAST5 BLOWFISH AES AES192 AES256 TWOFISH | PASS: encrypt.test
3DES CAST5 BLOWFISH AES AES192 AES256 TWOFISH | PASS: encrypt-dsa.test
PASS: seat.test
PASS: clearsig.test
PASS: encryptp.test
PASS: detach.test
PASS: armsigs.test
PASS: armencrypt.test
PASS: armencryptp.test
PASS: signencrypt.test
PASS: signencrypt-dsa.test
PASS: armsignencrypt.test
PASS: armdetach.test
PASS: armdetachm.test
PASS: detachm.test
PASS: genkey1024.test
3DES CAST5 BLOWFISH AES AES192 AES256 TWOFISH | PASS: conventional.test
3DES CAST5 BLOWFISH AES AES192 AES256 TWOFISH | PASS: conventional-mdc.test
PASS: multisig.test
PASS: verify.test
PASS: armor.test
===================
All 27 tests passed
===================
make[2]: Leaving directory `/home/gnupg-1.4.9/build-deb/checks'
make[1]: Leaving directory `/home/gnupg-1.4.9/build-deb/checks'

The current reversed logic causes the cross-build to fail for Emdebian Crush
because make check is normally disabled by passing nocheck, instead, gnupg
attempts to run the checks and the cross-build fails.



-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.28-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages gnupg depends on:
ii  gpgv                   1.4.9-4           GNU privacy guard - signature veri
ii  libbz2-1.0             1.0.5-1           high-quality block-sorting file co
ii  libc6                  2.9-6             GNU C Library: Shared libraries
ii  libreadline5           5.2-4             GNU readline and history libraries
ii  libusb-0.1-4           2:0.1.12-13       userspace USB programming library
ii  zlib1g                 1:1.2.3.3.dfsg-13 compression library - runtime

Versions of packages gnupg recommends:
ii  libldap-2.4-2                 2.4.15-1   OpenLDAP libraries

Versions of packages gnupg suggests:
ii  eog                    2.24.3.1-1        Eye of GNOME graphics viewer progr
pn  gnupg-doc              <none>            (no description available)
ii  imagemagick            7:6.3.7.9.dfsg2-1 image manipulation programs
ii  libpcsclite1           1.5.2-2           Middleware to access a smart card 

-- no debconf information