[Pkg-gnupg-maint] Bug#735363: [PATCH] init trustdb before trying to clear it

Dominic Hargreaves dom at earth.li
Sat Feb 15 18:07:47 UTC 2014


Control: severity -1 critical
Justification: makes unrelated software on the system break

On Tue, Jan 28, 2014 at 07:41:31PM +0000, Dominic Hargreaves wrote:
> Control: tags -1 + patch
> 
> On Mon, Jan 20, 2014 at 10:15:21PM -0500, Daniel Kahn Gillmor wrote:
> > This avoids failure when importing with --always-trust on gpg 1.4.16,
> > as reported in http://bugs.debian.org/735363
> > ---
> >  g10/trustdb.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/g10/trustdb.c b/g10/trustdb.c
> > index 0bf92e4..828b90f 100644
> > --- a/g10/trustdb.c
> > +++ b/g10/trustdb.c
> > @@ -927,6 +927,8 @@ clear_ownertrusts (PKT_public_key *pk)
> >    TRUSTREC rec;
> >    int rc;
> >  
> > +  init_trustdb();
> > +
> >    if (trustdb_args.no_trustdb && opt.trust_model == TM_ALWAYS)
> >      return 0;
> 
> I can confirm that this patch fixes the failures seen building
> request-tracker4. However, I am not in a position to assert its
> correctness - so it would be excellent if someone more familiar with
> the code could do so! And if the package maintainer desires, I can 
> help with an NMU.

On reflection, I'm upgrading the severity of this bug, since it's
blocking RC (FTBFS) bugs on multiple other packages.

Could someone familiar with gnupg's internals check Daniel's patch,
please (or Daniel do you feel confident to upload this without
further review?)

Thanks,
Dominic.



More information about the Pkg-gnupg-maint mailing list