[Pkg-gnupg-maint] Bug#773474: [PATCH] * scd/app-openpgp.c: (get_public_key) correctly close 'fp' upon use.

NIIBE Yutaka gniibe at fsij.org
Wed Jan 7 00:20:41 UTC 2015

On 12/20/2014 09:38 AM, Joshua Rogers wrote:
> Inside the get_public_key function, 'fp' was opened using popen, but incorrectly closed using fclose.
> From pclose(2):
>        The return value from popen() is a normal standard I/O stream in
>        all respects save that it must be closed with pclose() rather
>        than fclose(3).

Thank you for your patch.  Good catch.

I review it and I think that it's valid.  The bug is also there in 1.4
and 2.0.  The code path in question is for v1.0 card (which only
supports RSA-1024), so, the impact of this bug is considered not that

After you submitted this patch, you sent DCO.  I'd like to make sure
that your intention can be also applied to this patch?

I will apply this to 2.1 and backport to 1.4 and 2.0.

More information about the Pkg-gnupg-maint mailing list