[pkg-gnupg-maint] Bug#828109: Bug#828109: Bug#828109: gnupg2: does not react well to bad ECDSA subkey packet

[NIIBE Yutaka]

On 06/28/2016 02:43 AM, Daniel Kahn Gillmor wrote:
> On Mon 2016-06-27 02:25:33 -0400, NIIBE Yutaka wrote:
>> Sorry for the trouble because of my subkey.
> 
> thank you for being the experimental subject on whome the bugs are
> found, gniibe :)

Thanks, it's my pleasure.  :-)

>> And I found a bug for --list-packet option.  It's long standing, it's
>> there in 1.0.
>>
>> diff --git a/g10/mainproc.c b/g10/mainproc.c
>> index bd738ab..c191fe0 100644
>> --- a/g10/mainproc.c
>> +++ b/g10/mainproc.c
>> @@ -1328,7 +1328,7 @@ do_proc_packets (ctrl_t ctrl, CTX c, iobuf_t a)
>>            /* Stop processing when an invalid packet has been encountered
>>             * but don't do so when we are doing a --list-packets.  */
>>            if (gpg_err_code (rc) == GPG_ERR_INV_PACKET
>> -              && opt.list_packets != 2 )
>> +              && opt.list_packets == 0)
>>              break;
>>            continue;
>>  	}
>>
> 
> Sounds like this needs to be applied upstream, no?

Yes.  It should be applied to all versions (1.4, 2.0, and 2.1).  I'm
going to send a message to gnupg-devel, because it requires some
explanation, and possibly another clean up.

Basically, the usage of opt.list_packets is not good, it is changed
along with functions.  I don't like this kind of assignment.  Well,
it's not in Haskell...
--