[pkg-gnupg-maint] Bug#841143: [PATCH 3/4] gpg agent threading bugs: Add some `xxx' comments.

Ian Jackson ijackson at chiark.greenend.org.uk
Sun Jan 8 22:46:28 UTC 2017


I don't intend to fix these now because I think they're not really in
my way for getting the gpg agent races out of the way of dgit
development.

Signed-off-by: Ian Jackson <ijackson at chiark.greenend.org.uk>
---
 agent/gpg-agent.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/agent/gpg-agent.c b/agent/gpg-agent.c
index 1f92661..836b317 100644
--- a/agent/gpg-agent.c
+++ b/agent/gpg-agent.c
@@ -316,10 +316,10 @@ static int startup_signal_mask_valid;
 #endif
 
 /* Flag to indicate that a shutdown was requested.  */
-static int shutdown_pending;
+static int shutdown_pending; /* xxx threaded accesses lack locking */
 
 /* Counter for the currently running own socket checks.  */
-static int check_own_socket_running;
+static int check_own_socket_running; /* xxx threaded accesses lack locking */
 
 /* Flags to indicate that check_own_socket shall not be called.  */
 static int disable_check_own_socket;
@@ -328,7 +328,7 @@ static int disable_check_own_socket;
 static int is_supervised;
 
 /* Flag to inhibit socket removal in cleanup.  */
-static int inhibit_socket_removal;
+static int inhibit_socket_removal; /* xxx threaded accesses lack locking */
 
 /* It is possible that we are currently running under setuid permissions */
 static int maybe_setuid = 1;
-- 
2.11.0



More information about the pkg-gnupg-maint mailing list