[pkg-gnupg-maint] Bug#931954: sytemd user services are enabled twice

[Michael Biebl]

Package: gpg-agent
Version: 2.2.17-1
Severity: important
File: /usr/lib/systemd/user/gpg-agent.socket

Hi,

in 2.2.14-1, gnupg2 was switched to debhelper compat 12.
In that version, dh_installsystemduser is enabled by default.

As a result, the following files are created dynamically during
postinst:

/etc/systemd/user/sockets.target.wants/gpg-agent.socket
/etc/systemd/user/sockets.target.wants/gpg-agent-browser.socket
/etc/systemd/user/sockets.target.wants/gpg-agent-ssh.socket
/etc/systemd/user/sockets.target.wants/gpg-agent-extra.socket
/etc/systemd/user/sockets.target.wants/dirmngr.socket

At the same time, the package also ships static symlinks in /usr/lib:

/usr/lib/systemd/user/sockets.target.wants/gpg-agent.socket
/usr/lib/systemd/user/sockets.target.wants/gpg-agent-browser.socket
/usr/lib/systemd/user/sockets.target.wants/gpg-agent-ssh.socket
/usr/lib/systemd/user/sockets.target.wants/gpg-agent-extra.socket
/usr/lib/systemd/user/sockets.target.wants/dirmngr.socket

Those symlinks in /usr/lib/ date back iirc to a time when whe didn't
have dh_installsystemduser where I recommended to ship the enablement
symlinks directly in the package.

Since those are no longer necessary now, I would recommend removing
/usr/lib/systemd/user/sockets.target.wants/gpg-agent.socket
/usr/lib/systemd/user/sockets.target.wants/gpg-agent-browser.socket
/usr/lib/systemd/user/sockets.target.wants/gpg-agent-ssh.socket
/usr/lib/systemd/user/sockets.target.wants/gpg-agent-extra.socket
/usr/lib/systemd/user/sockets.target.wants/dirmngr.socket

like in the attached patch.


Regards,
Michael


-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages gpg-agent depends on:
ii  gpgconf                     2.2.17-1
ii  init-system-helpers         1.57
ii  libassuan0                  2.5.3-2
ii  libc6                       2.28-10
ii  libgcrypt20                 1.8.4-5
ii  libgpg-error0               1.36-2
ii  libnpth0                    1.6-1
ii  pinentry-curses [pinentry]  1.1.0-2
ii  pinentry-gnome3 [pinentry]  1.1.0-2
ii  pinentry-gtk2 [pinentry]    1.1.0-2
ii  pinentry-qt [pinentry]      1.1.0-2

Versions of packages gpg-agent recommends:
ii  gnupg  2.2.17-1

Versions of packages gpg-agent suggests:
ii  dbus-user-session  1.12.16-1
ii  libpam-systemd     242-2
ii  pinentry-gnome3    1.1.0-2
pn  scdaemon           <none>

-- Configuration Files:
/etc/logcheck/ignore.d.server/gpg-agent [Errno 13] Keine Berechtigung: '/etc/logcheck/ignore.d.server/gpg-agent'

-- no debconf information
-------------- next part --------------
diff --git a/debian/gpg-agent.links b/debian/gpg-agent.links
index 90f6ce115..292770149 100644
--- a/debian/gpg-agent.links
+++ b/debian/gpg-agent.links
@@ -1,6 +1,2 @@
 usr/lib/gnupg/gpg-preset-passphrase usr/lib/gnupg2/gpg-preset-passphrase
 usr/lib/gnupg/gpg-protect-tool usr/lib/gnupg2/gpg-protect-tool
-usr/lib/systemd/user/gpg-agent-browser.socket usr/lib/systemd/user/sockets.target.wants/gpg-agent-browser.socket
-usr/lib/systemd/user/gpg-agent-extra.socket usr/lib/systemd/user/sockets.target.wants/gpg-agent-extra.socket
-usr/lib/systemd/user/gpg-agent-ssh.socket usr/lib/systemd/user/sockets.target.wants/gpg-agent-ssh.socket
-usr/lib/systemd/user/gpg-agent.socket usr/lib/systemd/user/sockets.target.wants/gpg-agent.socket