[pkg-gnupg-maint] Bug#993857: Bug#993857: Bug#993857: gnupg2: Please remove librsvg2-bin from BD

[Laurent Bigonville]

On 8/01/22 20:04, Daniel Kahn Gillmor wrote:
> Control: reopen 993857
> Control: retitle 993857 gnupg2: gnupg-module-overview.png is not built from source
>
> On Wed 2021-12-15 23:40:23 +0100, Christoph Biedl wrote:
>> Control: tags 993857 pending
>>
>> Laurent Bigonville wrote...
>>
>>> Could you please drop librsvg2-bin from the build-dependencies?
>> (...)
>>
>> Comparing the built packages before and after removing that build
>> dependency shows no differences, so it should be safe to drop it.
> [...]
> So the debian-generated image is both more policy-compliant and more
> correct.  We shouldn't stop building it from source.
>
> What's the right way to go to build this on systems where we don't have
> rust?  Here's one idea (i haven't tried it yet):
>
> - ensure that gnupg-module-overview.png is shipped in an
>    architecture-independent package (e.g. gnupg itself, which is an
>    Architecture: all metapackage).  This is where it is today, so far so
>    good.
>
> - move the build-deps for it (including imagemagick and librsvg2-bin)
>    into the Build-Depends-Indep: section
>
> - maybe put those build-deps behind a <!nodoc> build profile flag for
>    minimizing dependencies (see https://wiki.debian.org/BuildProfileSpec)
>
> - ensure that the binary packages build cleanly anyway
>
> - ensure that the arch-independent builds actually do rebuild the .png
>    (we might need to delete it before the build depending on the
>    timestamps in the tarball)
>
> Laurent, would that approach satisfy your concerns on rust-less
> architectures?  Those arches could of course install the
> arch-independent packages that were built on platforms like amd64 which
> have rust available.

Thanks for your feedback.

My understanding of the policy has always been that the source tarball 
shipped in debian must indeed contain all the files in their "preferred 
form of modification" but the fact that the resulting artifact has to be 
rebuilt during the build of the package was merely a recommendation. 
Here we have both the .svg and the .png file shipped in the tarball, so 
that looks DFSG compatible to me.

My main concern here was to be certain that gnupg can build all 
architectures even the one without rust support and your proposal allows 
this, so it's good for me and if you think it's better to rebuild the 
image during the build I've no objections.

The fact that there is a rendering problem with the .png shipped in the 
upstream tarball should be reported in any case I think.

Kind regards,

Laurent Bigonville