[pkg-gnupg-maint] Bug#1066137: Bug#1066137: gnupg2: -Werror=implicit-function-declaration failure testing for ldap_open

[Sune Stolborg Vuorela]

On Tuesday, March 12, 2024 11:56:48 PM CET Thorsten Glaser wrote:
> Source: gnupg2
> Version: 2.2.40-1.1
> Severity: serious
> Justification: ftbfs
> X-Debbugs-Cc: tg at mirbsd.de
> 
> Trying to binNMU gnupg2 to make it installable during t64 transition,
> I notice the following configury output:

apparantly since some version, ldap_open prototype is put behind 
#if LDAP_DEPRECATED

Given the only reference to ldap_open is in the configure script, I guess a 
quickfix could be to just define that in the m4 scripts / configure scripts as a 
minimal change.

> 
> | /* end confdefs.h.  */
> | 
> | #ifdef _WIN32
> | #include <winsock2.h>
> | #include <winldap.h>
> | #else
#if LDAP_DEPRECATED

> | #include <ldap.h>
> | #endif
> | 
> | int
> | main (void)
> | {
> | ldap_open("foobar",1234);
> | 
> |   ;
> |   return 0;
> | 
> | }
> 
> configure:11608: result: no
> 
> 
> Prototypes are now mandatory, both for C23 and because the t64 transition
> can only work if prototypes are properly used.

I'm a bit surprised the way ldap has decided to deprecate functions, but I 
guess users needs to work with it.

/Sune
-- 
I didn’t stop pretending when I became an adult, it’s just that when I was a 
kid I was pretending that I fit into the rules and structures of this world. 
And now that I’m an adult, I pretend that those rules and structures exist.
   - zefrank