[pkg-gnupg-maint] Bug#1097574: pgpdump: ftbfs with GCC-15

[Matthias Klose]

Package: src:pgpdump
Version: 0.36-1
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/pgpdump_0.36-1_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
pgpdump.h:153:13: note: ‘signer_user_id’ declared here
  153 | public void signer_user_id(int);
      |             ^~~~~~~~~~~~~~
packet.c:233:9: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(int)’ [-Wincompatible-pointer-types]
  233 |         reason_for_revocation,
      |         ^~~~~~~~~~~~~~~~~~~~~
packet.c:233:9: note: (near initialization for ‘sigsub_func[29]’)
pgpdump.h:154:13: note: ‘reason_for_revocation’ declared here
  154 | public void reason_for_revocation(int);
      |             ^~~~~~~~~~~~~~~~~~~~~
packet.c:234:9: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(int)’ [-Wincompatible-pointer-types]
  234 |         features,
      |         ^~~~~~~~
packet.c:234:9: note: (near initialization for ‘sigsub_func[30]’)
pgpdump.h:155:13: note: ‘features’ declared here
  155 | public void features(int);
      |             ^~~~~~~~
packet.c:235:9: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(int)’ [-Wincompatible-pointer-types]
  235 |         signature_target,
      |         ^~~~~~~~~~~~~~~~
packet.c:235:9: note: (near initialization for ‘sigsub_func[31]’)
pgpdump.h:156:13: note: ‘signature_target’ declared here
  156 | public void signature_target(int);
      |             ^~~~~~~~~~~~~~~~
packet.c:236:9: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(int)’ [-Wincompatible-pointer-types]
  236 |         embedded_signature,
      |         ^~~~~~~~~~~~~~~~~~
packet.c:236:9: note: (near initialization for ‘sigsub_func[32]’)
pgpdump.h:157:13: note: ‘embedded_signature’ declared here
  157 | public void embedded_signature(int);
      |             ^~~~~~~~~~~~~~~~~~
packet.c:237:9: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(int)’ [-Wincompatible-pointer-types]
  237 |         issuer_fingerprint,
      |         ^~~~~~~~~~~~~~~~~~
packet.c:237:9: note: (near initialization for ‘sigsub_func[33]’)
pgpdump.h:158:13: note: ‘issuer_fingerprint’ declared here
  158 | public void issuer_fingerprint(int);
      |             ^~~~~~~~~~~~~~~~~~
packet.c:238:9: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(int)’ [-Wincompatible-pointer-types]
  238 |         preferred_aead_algorithms,
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
packet.c:238:9: note: (near initialization for ‘sigsub_func[34]’)
pgpdump.h:142:13: note: ‘preferred_aead_algorithms’ declared here
  142 | public void preferred_aead_algorithms(int);
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~
packet.c:251:9: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(int)’ [-Wincompatible-pointer-types]
  251 |         image_attribute,
      |         ^~~~~~~~~~~~~~~
packet.c:251:9: note: (near initialization for ‘uatsub_func[1]’)
pgpdump.h:164:13: note: ‘image_attribute’ declared here
  164 | public void image_attribute(int);
      |             ^~~~~~~~~~~~~~~
packet.c: In function ‘parse_packet’:
packet.c:365:26: error: too many arguments to function ‘tag_func[tag]’; expected 0, have 1
  365 |                         (*tag_func[tag])(len);
      |                         ~^~~~~~~~~~~~~~~ ~~~
packet.c: In function ‘parse_signature_subpacket’:
packet.c:421:26: error: too many arguments to function ‘sigsub_func[subtype]’; expected 0, have 1
  421 |                         (*sigsub_func[subtype])(len);
      |                         ~^~~~~~~~~~~~~~~~~~~~~~ ~~~
packet.c: In function ‘parse_userattr_subpacket’:
packet.c:456:26: error: too many arguments to function ‘uatsub_func[subtype]’; expected 0, have 1
  456 |                         (*uatsub_func[subtype])(len);
      |                         ~^~~~~~~~~~~~~~~~~~~~~~ ~~~
make[1]: *** [Makefile:27: packet.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/build/reproducible-path/pgpdump-0.36'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:6: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2