[Debian GNUstep maintainers] preview.app uploaded to mentors

[Federico Gimenez Nieto]

Ok, i've uploaded a new version with all these changes applied.

http://mentors.debian.net/debian/pool/main/p/preview.app/preview.app_0.8.5-6.dsc

Thanks again, cheers
Federico

On Sat, 2009-11-28 at 13:35 +0200, Yavor Doganov wrote:
> Federico Gimenez Nieto wrote:
> > > You need to add a preinst script to remove the old Resources dir.
> 
> > Ok, done.
> 
> Minor nit: It can be called simply `preinst', and no need to be
> executable; debhelper will do its job.
> 
> > Ok, done, GNUSTEP_MAKEFILES exported at the beginning of debian/rules
> 
> I would do it like this (of course, yours is not wrong, just a matter
> of personal preference):
> 
>    export GNUSTEP_MAKEFILES := $(GS_MAKE_DIR)
> 
> > This cp came from the previous version. It seems to copy
> > English.lproj/Preview.gorm/* to French.lproj/Preview.gorm/ within the
> > Resources directory, and in my opinion it should be still needed after
> > the move of the whole Resources directory, please correct me if i am
> > wrong.
> 
> Ah, indeed.  This is because French.lproj/Preview.gorm is an empty
> directory (apparently not translated).  Don't worry about that, you
> can safely avoid copying the English .gorm file -- if the translated
> one is not found, the English one will be loaded automatically at
> runtime.
> 
> > There are three tiff images that could be used, FileIcon_jpeg.tiff,
> > FileIcon_png.tiff and FileIcon_tiff.tiff, all of 48x48 pixels in size,
> > will any of them work as a menu icon?
> 
> AFAICS it's Preview.tiff that you need to convert to XPM; that's the
> app icon.
> 
> > > 11) You can get rid of the dpkg-shlibdeps warnings (if they annoy you)
> > >     with LDFLAGS,
> 
> > Ok, added LDFLAGS
> 
> But it's not in effect; you have to pass it on the command line, like
> this:
> 
> build-stamp:
> 	...
> 	$(MAKE) OPTFLAG=$(OPTFLAG) LDFLAGS="$(LDFLAGS)" messages=yes
> 
> (The quotes are important, as the variable's value contains spaces.)
> 
> > I've uploaded a new version with all these changes,
> 
> Looks good otherwise.  Thanks.
> 
> _______________________________________________
> Debian GNUstep maintainers mailing list
> pkg-GNUstep-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-gnustep-maintainers
-- 
Federico Giménez Nieto
fgimenez at coit.es