[Debian GNUstep maintainers] First version of split gnustep-dl2 at mentors

[Federico Giménez Nieto]

Hi Yavor, thanks for your reply,

2010/2/18 Yavor Doganov <yavor at gnu.org>:
> Here are some from me, without carefully checking the package:
>
> * debian/changelog should document *all* changes, particularly the
>  newly added binary packages.
>

I forgot, done

> * Every new binary package should have Replaces: gnustep-dl2,
>  otherwise this is what happens:
>
>  Selecting previously deselected package gnustep-dl2-sqlite-adaptor.
>  Unpacking gnustep-dl2-sqlite-adaptor (from .../gnustep-dl2-sqlite-adaptor_0.12.0-1_i386.deb) ...
>  dpkg: error processing ../gnustep-dl2-sqlite-adaptor_0.12.0-1_i386.deb (--install):
>   trying to overwrite '/usr/lib/GNUstep/Frameworks/PostgreSQLEOAdaptor.framework/Versions/0/Headers/PostgreSQLAdaptor.h', which is also in package gnustep-dl2-postgresql-adaptor 0:0.12.0-1
>

Ok, added the 'Replaces' statement. The error about
gnustep-dl2-sqlite-adaptor may be related to a wrong install command
for that package, which grabbed the postgresql adaptor code instead of
the sqlite3 code. That is already corrected.

However, now the sqliteAdaptor build directory is empty, the previous
unified package version gives a directory with two broken symlinks. In
config.log, the only references to sqlite3 indicates that two header
files and the database are not present, although the sqlite3 package
is installed (is there a missing build-dependency here?), any idea of
what is happening with this?

>  BTW, as adivised by upstream (David Ayers), please delete all
>  PostreSQLEOAdaptor headers (from within debian/rules is fine).
>

Done

> * Please ship EOModeller as a private library under
>  /usr/lib/gnustep-dl2 in the gnustep-dl2 binary package.  The way to
>  achieve this is with a few more commands in the rules, I think.  If
>  you encounter difficulties, let me know.
>

I've read that setting LD_LIBRARY_PATH could help, don't know how to do it.

> * libgnustep-dl2-dev should Depends: libgnustep-gui-dev, so that
>  installing this package pulls in all relevant needed packages.
>

Done

> * Description: For the adaptors, you'd probably want to make it more
>  obvious in the short description that it's about GDL2.
>

Done

> * Not sure why you invent so many per-package targets?  Isn't the job
>  done by `dh_install' + .install files sufficient?
>

Well, i tried to distinguish the required commands for each package,
not at all necessary and error prone, now there is a single call to
all of them at the binary-arch target.

> * Duplicated dependency for the adaptors:
>  libgnustep-dl2-0, libgnustep-dl2-0 (>= 0.12.0)
>  (I haven't investigated the cause, but most probably excessive
>  debian/rules dance.)
>

This may be related to a shlibs.local file that i was using when
fixing libraries dependencies, it included an unversioned dependency.
Now that file is removed, testing with dpkg-deb -I doesn't reports the
unversioned dependency.

> * -sqlite-adaptor depends on libpq5, surprisingly (see also the dpkg
>  error message above).  It seems to include the same conents as the
>  -postgresql-adaptor, which is obviously wrong.
>

Yes, this is probably due to the wrong install command, that is
corrected, but * -sqlite-adaptor is not building...

> * You haven't overriden package-name-doesnt-match-sonames tags; please
>  don't do it as they are legitimate.  If a potential sponsor objects,
>  please point her to the discussion we had at gnustep-dev
>  (e.g. http://thread.gmane.org/gmane.comp.lib.gnustep.devel/8394).
>
>

Ok, the new version is uploaded [1]

Cheers
Federico

[1] http://mentors.debian.net/debian/pool/main/g/gnustep-dl2/gnustep-dl2_0.12.0-1.dsc