[Debian GNUstep maintainers] Bug#749737: charmap.app: GCC warnings that may lead to runtime issues with new GNUstep libraries

[Yavor Doganov]

Source: charmap.app
Version: 0.2-11
Severity: normal
Tags: sid jessie
User: pkg-gnustep-maintainers at lists.alioth.debian.org
Usertags: gnustep-base1.24-transition gnustep-gui0.24-transition gnustep-transition

Your package builds successfully with the new GNUstep libraries, but
there are some GCC warnings that *may* lead to problems at runtime and
may affect the forthcoming gnustep transition/jessie release.  Latest
versions of the core GNUstep packages are available at mentors.d.n [*];
they will be uploaded to experimental first.

Please note that the warnings may be unrelated to GNUstep or changes in
GNUstep but could be legitimate nevertheless.  In case the fix is
applicable for the current gnustep-* library packages in sid (-base/1.22
and -gui/0.20) you can upload the fixed package before the transition
begins.  Otherwise, please wait for the transition to complete and
do not forget to adjust the Build-Depends field accordingly:

  libgnustep-base-dev (>= 1.24.6)
  or
  libgnustep-gui-dev (>= 0.24)

Relevant portion(s) of the log:

Controller.m: In function '-[Controller awakeFromNib]':
Controller.m:53:13: warning: initialization from distinct Objective-C type [enabled by default]
             defaultParagraphStyle];
             ^
[...]
Controller.m: In function '-[Controller updateInspector:]':
Controller.m:322:11: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
   for (cs = [character UTF8String]; *cs != '\0'; cs++)
           ^
Controller.m:328:11: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
   for (cs = [character UTF8String]; *cs != '\0'; cs++)
           ^
[...]
UnicodeData.m: In function '-[UnicodeData unihanDictionaryForCharacter:]':
UnicodeData.m:506:4: warning: pointer targets in passing argument 1 of '__builtin_strchr' differ in signedness [-Wpointer-sign]
    c = strchr(big_buf, '\t') + 1;
    ^
UnicodeData.m:506:4: note: expected 'const char *' but argument is of type 'unsigned char *'
UnicodeData.m:506:6: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
    c = strchr(big_buf, '\t') + 1;
      ^
UnicodeData.m:507:4: warning: pointer targets in passing argument 1 of '__builtin_strchr' differ in signedness [-Wpointer-sign]
    c = strchr(c, '\t') + 1;
    ^
UnicodeData.m:507:4: note: expected 'const char *' but argument is of type 'unsigned char *'
UnicodeData.m:507:6: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
    c = strchr(c, '\t') + 1;
      ^
UnicodeData.m:508:4: warning: pointer targets in passing argument 1 of 'initWithUTF8String:' differ in signedness [-Wpointer-sign]
    value = [[NSString alloc] initWithUTF8String: c];
    ^
UnicodeData.m:508:4: note: expected 'const char *' but argument is of type 'unsigned char *'
UnicodeData.m:510:4: warning: pointer targets in passing argument 1 of '__builtin_strchr' differ in signedness [-Wpointer-sign]
    c = strchr(big_buf, '\t') + 1;
    ^
UnicodeData.m:510:4: note: expected 'const char *' but argument is of type 'unsigned char *'
UnicodeData.m:510:6: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
    c = strchr(big_buf, '\t') + 1;
      ^
UnicodeData.m:511:4: warning: pointer targets in passing argument 1 of '__builtin_strchr' differ in signedness [-Wpointer-sign]
    *strchr(c, '\t') = 0;
    ^
UnicodeData.m:511:4: note: expected 'const char *' but argument is of type 'unsigned char *'
UnicodeData.m:512:4: warning: pointer targets in passing argument 1 of 'initWithUTF8String:' differ in signedness [-Wpointer-sign]
    key = [[NSString alloc] initWithUTF8String: c];
    ^
UnicodeData.m:512:4: note: expected 'const char *' but argument is of type 'unsigned char *'


The full build log is available upon request.
The severity of this bug may be raised to "important", "serious" or
"grave" after the transition depending on the impact.

[*]
http://mentors.debian.net/debian/pool/main/g/gnustep-make/gnustep-make_2.6.6-1.dsc
http://mentors.debian.net/debian/pool/main/g/gnustep-base/gnustep-base_1.24.6-1.dsc
http://mentors.debian.net/debian/pool/main/g/gnustep-gui/gnustep-gui_0.24.0-1.dsc
http://mentors.debian.net/debian/pool/main/g/gnustep-back/gnustep-back_0.24.0-1.dsc