[Debian GNUstep maintainers] Bug#767847: gworkspace: FTBFS on hurd-i386

Svante Signell svante.signell at gmail.com
Fri Dec 22 23:31:37 UTC 2017


On Thu, 2017-12-21 at 00:22 +0200, Yavor Doganov wrote:
> Ivan Vučica wrote:
> > Also malloc(...)+1 should be malloc(...+1).
> 
> That's right, it is the latter in my patch.
> 
> > Also strncpy() IIRC doesn’t add a nul terminator.
> 
> Correct, it is added with a special assignment after the loop, so
> this is already handled.
> 
> > How about calloc() to also zero the memory out, or at least
> > newpath[newblen] = 0? (Or the equivalent in the new patch.)
> 
> Perhaps this is a good idea.
> 
> > Alternatively just use ObjC to manipulate strings of UTF8 text.
> 
> The usual approach in fixing arch-specific bugs, at least in Debian,
> is to try not to diverge much from the existing code.  Of course ObjC
> can be used, probably even SQLClient.

Hi, it seems like the patch by Yavor is fine. Please apply it to the
next Debian release (and consider it going upstream). And, I'm a little
astonished that such an old bug pops up now, it was filed in 2014. Are
you Yavor the new maintainer?



More information about the pkg-GNUstep-maintainers mailing list