[Debian GNUstep maintainers] Bug#908512: Docked apps icons appear broken (with a standard icon)

[Yavor Doganov]

On Fri, 25 Jan 2019 19:06:17 +0200,
Yavor Doganov wrote:
> On Sun, Sep 16, 2018 at 08:12:38PM +0300, Yavor Doganov wrote:
> > On Mon, Sep 10, 2018 at 07:32:16PM +0200, Gürkan Myczko wrote:
> > > And the following GNUstep applications (once the apps are launched,
> > > an icon appears). but for TalkSoup.app, VolumeControl.app, and
> > > TextEdit.app they are not 64x64, more like 32x32...
> > 
> > This is a known issue; I believe it is fixed in git master.
> 
> This bug is definitely not fixed; I'll investigate when I find the
> time.

I found where the problem is for TalkSoup, TextEdit and Lynkeos but
would like to test my fix a bit more before I propose it upstream.

For VolumeControl, the issue seems to be the image itself:

$ tiffinfo /usr/share/GNUstep/VolumeControl.app/headphones.tiff | grep -E '(Ima|Res)'
  Image Width: 64 Image Length: 64
  Resolution: 150, 150 pixels/inch

You would need to set the resulotion to 72 if you want it to match the
actual width/height.  For example:

$ tiffinfo /usr/share/GNUstep/Preview.app/Preview.tiff | grep -E '(Ima|Res)'
  Image Width: 45 Image Length: 45
  Resolution: 72, 72 pixels/inch
$ tiffinfo /usr/share/GNUstep/SimpleAgenda.app/Calendar.tiff | grep -E '(Ima|Res)'
  Image Width: 64 Image Length: 64
  Resolution: 72, 72 pixels/inch

Granted, I remeber this worked in the past as VolumeControl's icon
used to be displayed normally.  Apparently that's no longer the case
as some rescaling is happening:

Breakpoint 1, -[NSAppIconView setImage:] (self=0x555555807510, 
    _cmd=0x7ffff7d11f40 <_OBJC_SELECTOR_TABLE+5088>, anImage=0x555555d263b0)
    at NSApplication.m:712
712	NSApplication.m: Няма такъв файл или директория.
(gdb) po anImage
<NSImage 0x555555d263b0 Name=(null) Size={width = 30.72; height = 30.72} Reps=("<NSBitmapImageRep: 0x555555d266f0 size: {width = 30.72; height = 30.72} pixelsWide: 64 pixelsHigh: 64 colorSpaceName: NSDeviceRGBColorSpace bps: 8>")>

Notice the actual size is 30.72 x 30.72.  If I rescale the image with
GIMP, decreasing the resolution from 150 to 72 (Image->Scale Image...),
it is displayed properly and I get:

(gdb) po anImage
<NSImage 0x555555794de0 Name=(null) Size={width = 64; height = 64} Reps=("<NSBitmapImageRep: 0x555555d26f40 size: {width = 64; height = 64} pixelsWide: 64 pixelsHigh: 64 colorSpaceName: NSDeviceRGBColorSpace bps: 8>")>

Perhaps that's something that you should fix in the new upstream
release along with #920629.