[Debian GNUstep maintainers] Bug#1044313: gnustep-sqlclient: Fails to build source after successful build

[Lucas Nussbaum]

Source: gnustep-sqlclient
Version: 1.9.0-2
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -----------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package gnustep-sqlclient
> dpkg-buildpackage: info: source version 1.9.0-2
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Yavor Doganov <yavor at gnu.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    dh_auto_clean
> 	make -j8 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> This is gnustep-make 2.9.1. Type 'make print-gnustep-make-help' for help.
> Running in gnustep-make version 2 strict mode.
> rm -rf ./*~ ./obj
> (cd .; \
> rm -rf         ECPG.bundle Postgres.bundle MySQL.bundle SQLite.bundle)
> rm -f ECPG.m Oracle.m
> rm -f config.h config.make config.log config.status
> rm -rf autom4te.cache
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean
>    debian/rules override_dh_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> rm -f -r Bundles
> dh_clean test test.conf debian/libsqlclient-dev.{install,links}
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: verifying ./gnustep-sqlclient_1.9.0.orig.tar.gz.asc
> gpgv: Signature made Fri Jan 13 15:01:59 2023 UTC
> gpgv:                using DSA key 83AAE47CE829A4146EF83420CA868D4C99149679
> gpgv:                issuer "gnustep-maintainer at gnu.org"
> gpgv: Note: signatures using the SHA1 algorithm are rejected
> gpgv: Can't check signature: Bad public key
> dpkg-source: warning: cannot verify upstream tarball signature for ./gnustep-sqlclient_1.9.0.orig.tar.gz: no acceptable signature found
> dpkg-source: info: building gnustep-sqlclient using existing ./gnustep-sqlclient_1.9.0.orig.tar.gz
> dpkg-source: info: building gnustep-sqlclient using existing ./gnustep-sqlclient_1.9.0.orig.tar.gz.asc
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: ignoring deletion of file configure, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file config.h.in, use --include-removal to override
> dpkg-source: warning: file gnustep-sqlclient-1.9.0/SQLClient/OrderedSymbolDeclarations.plist has no final newline (either original or modified version)
> dpkg-source: warning: file gnustep-sqlclient-1.9.0/SQLClient/SQLClient.igsdoc has no final newline (either original or modified version)
> dpkg-source: warning: file gnustep-sqlclient-1.9.0/SQLClient/dependencies has no final newline (either original or modified version)
> dpkg-source: info: local changes detected, the modified files are:
>  gnustep-sqlclient-1.9.0/SQLClient/OrderedSymbolDeclarations.plist
>  gnustep-sqlclient-1.9.0/SQLClient/SQLClient.gsdoc
>  gnustep-sqlclient-1.9.0/SQLClient/SQLClient.html
>  gnustep-sqlclient-1.9.0/SQLClient/SQLClient.igsdoc
>  gnustep-sqlclient-1.9.0/SQLClient/dependencies
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/gnustep-sqlclient_1.9.0-2.diff.vizrAX
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/gnustep-sqlclient_1.9.0-2_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.