[Debian GNUstep maintainers] Bug#1091252: chess.app: FTBFS on armhf: gnuchess.c:523:16: error: passing argument 1 of ‘time’ from incompatible pointer type [-Wincompatible-pointer-types]

[Lucas Nussbaum]

Source: chess.app
Version: 2.8-5
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20241223 ftbfs-trixie

Hi,

During a rebuild of all packages in sid, this package failed to build
on armhf.

This package currently has binary packages on armhf, so this is a regression.
Also, there are no known issues on amd64 or arm64 according to recent (a couple
days ago) rebuilds.

The rebuild was done using an armhf chroot on an AWS "m6g" instance (Graviton2
CPU).

Relevant part (hopefully):
> gcc gnuchess.c -c \
>       -MMD -MP -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 -DGNUSTEP -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNU_GUI_LIBRARY=1 -DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 -pthread -pthread -fPIC -Wall -DGSWARN -DGSDIAGNOSE -Wno-import -g -O2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -I. -I/usr/local/include/GNUstep -I/usr/include/GNUstep \
>        -o obj/Chess.obj/gnuchess.c.o
> gnuchess.c: In function ‘NewGame’:
> gnuchess.c:523:16: error: passing argument 1 of ‘time’ from incompatible pointer type [-Wincompatible-pointer-types]
>   523 |   time0 = time((long *)0);
>       |                ^~~~~~~~~
>       |                |
>       |                long int *
> In file included from /usr/include/features.h:510,
>                  from /usr/include/arm-linux-gnueabihf/bits/libc-header-start.h:33,
>                  from /usr/include/stdio.h:28,
>                  from gnuchess.c:39:
> /usr/include/time.h:85:15: note: expected ‘time_t *’ {aka ‘long long int *’} but argument is of type ‘long int *’
>    85 | extern time_t __REDIRECT_NTH (time, (time_t *__timer), __time64);
>       |               ^~~~~~~~~~~~~~
> gnuchess.c: In function ‘ataks’:
> gnuchess.c:1749:22: warning: operation on ‘*(a + (sizetype)((unsigned int)u * 2))’ may be undefined [-Wsequence-point]
>  1749 |                 a[u] = ++a[u] | c;
>       |                 ~~~~~^~~~~~~~~~~~
> gnuchess.c:1759:20: warning: operation on ‘*(a + (sizetype)((unsigned int)u * 2))’ may be undefined [-Wsequence-point]
>  1759 |               a[u] = ++a[u] | c;
>       |               ~~~~~^~~~~~~~~~~~
> gnuchess.c: In function ‘KingScan’:
> gnuchess.c:2048:6: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else]
>  2048 |   if (color[u] != c2)                           \
>       |      ^
> gnuchess.c:2066:34: note: in expansion of macro ‘ScoreThreat’
>  2066 |             if (atk2[u] & ctlBQ) ScoreThreat;
>       |                                  ^~~~~~~~~~~
> gnuchess.c:2048:6: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else]
>  2048 |   if (color[u] != c2)                           \
>       |      ^
> gnuchess.c:2078:34: note: in expansion of macro ‘ScoreThreat’
>  2078 |             if (atk2[u] & ctlRQ) ScoreThreat;
>       |                                  ^~~~~~~~~~~
> gnuchess.c:2048:6: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else]
>  2048 |   if (color[u] != c2)                           \
>       |      ^
> gnuchess.c:2088:32: note: in expansion of macro ‘ScoreThreat’
>  2088 |           if (atk2[u] & ctlNN) ScoreThreat;
>       |                                ^~~~~~~~~~~
> make[5]: *** [/usr/share/GNUstep/Makefiles/rules.make:528: obj/Chess.obj/gnuchess.c.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/12/23/chess.app_2.8-5_unstable-armhf.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20241223;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20241223&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.