Bug#662100: p11-kit: CPPFLAGS hardening flags missing

[Simon Ruderich]

Package: p11-kit
Severity: important
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Dear Maintainer,

The CPPFLAGS hardening flags are not used in the build.

The problem is "export CPPFLAGS" in debian/rules. I'm not
entirely sure why it causes the problem, but I guess the export
happens while parsing the Makefile - which overwrites the
hardening flags which get added later. The following patch fixes
that:

diff -Nru p11-kit-0.11/debian/rules p11-kit-0.11/debian/rules
- --- p11-kit-0.11/debian/rules	2012-03-03 18:53:22.000000000 +0100
+++ p11-kit-0.11/debian/rules	2012-03-04 04:44:20.000000000 +0100
@@ -1,7 +1,6 @@
 #!/usr/bin/make -f
 
 CPPFLAGS += -D_XOPEN_SOURCE=600 -D_BSD_SOURCE
- -export CPPFLAGS
 
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1

To check if all flags were correctly enabled you can use
`hardening-check` from the hardening-includes package:

    $ hardening-check /usr/bin/p11-kit /usr/lib/x86_64-linux-gnu/libp11-kit.so.0.0.0
    /usr/bin/p11-kit:
     Position Independent Executable: no, normal executable!
     Stack protected: yes
     Fortify Source functions: yes
     Read-only relocations: yes
     Immediate binding: no not found!
    /usr/lib/x86_64-linux-gnu/libp11-kit.so.0.0.0:
     Position Independent Executable: no, regular shared library (ignored)
     Stack protected: yes
     Fortify Source functions: yes (some protected functions found)
     Read-only relocations: yes
     Immediate binding: no not found!

For more information please have a look at [1], [2] and [3].

Regards,
Simon

[1]: https://wiki.debian.org/ReleaseGoals/SecurityHardeningBuildFlags
[2]: https://wiki.debian.org/HardeningWalkthrough
[3]: https://wiki.debian.org/Hardening

- -- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJPUubpAAoJEJL+/bfkTDL5Je0P/3SH1qCNJAPTYAyOove2YeCr
iUJWAzSH43+9UkEMEMWlayfWuoIq2RrYVH6yaUSvEU4g7cZiOiSheNi3Ee9jimda
jA2Sz8u9uJKLO+wKSR4GoiF4nf2ctgZFBa/ssIUwjDZfSJpJWjTEhgNCeb+ar+xM
cTS8F/8MZUNQbOXWJMFL2U9MBdjYX9jBKTUF6Sz5QVLikT6wxyf7LCp0xt5SM1RT
3u8lNwacbqZ8KOJ+m1EASIvp/+6kCZszDtoMpkvqAnfJL9/ODgEyS+Q/x8XAyqcF
CzRvCBR/2oSpFhFYldRjyl4NSAMCiZcMwxIL72alk3vssTdiyyTKk+xY+pL2msba
rCA3dN8o31TvUdAZXk7VkUtihlfyHCozDqtJEILpjIIo7PfgUrnXNHSag7vL1bo4
iQsa6cqqibWM3/fejogtPsVSp6B9lh2p5Lw/ph4A/C5g4L+TJxYxyGPdTn8t5mFD
HRUrA4ahw5bYo2OxXwHjdTSj5MTvOAXSZndyGerGD6+qj11/FlF/uckd0iGsX286
mTi7IK50DV87+wjSrlLnGXdIpfHY/W3y0D2v587o9Hco6+gq30TIQYatQY+pSKJW
3vn4X1wcKJWhVPjaYOy2TLpFiVft/E5KaKL99voXswEorqVa3AXbh/fGXG6OneqN
H/mCbHuiRyArAfP/Yl6j
=Qx0C
-----END PGP SIGNATURE-----