Bug#658896: Please apply patch no_global_init_during_thread_callbacks.diff

[Carlos Alberto Lopez Perez]

On 23/01/13 19:30, Carlos Alberto Lopez Perez wrote:
> On 23/01/13 19:04, Andreas Metzler wrote:
>> On 2013-01-23 Carlos Alberto Lopez Perez <clopez at igalia.com> wrote:
>>> severity 658896 serious
>>> thanks
>>> justification: Breaks unrelated software. It renders sudo unusable on systems with LDAP/PAM
>> [...]
>>
>>> What fixed the issue was applying the patch no_global_init_during_thread_callbacks.diff
>>> from http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=658896#28
>>
>>
>>> I'm attaching the debdiff. I rebuilt libgcrypt11 with the attached debdiff.
>>> After installing it, sudo works as expected.
>> [...]
>>
>> According to the experiences in Ubuntu it breaks other stuff:
>> https://bugs.launchpad.net/ubuntu/+source/libgcrypt11/+bug/1013798
>> (+ 2 merged bugreports)
>>
>> I do not know whether this is a fair exchange, or whether it could
>> be fixed simply. However applying the patch clearly comes at a cost.
>>
>> I am sorry I cannot be more helpful, but I am just not a programmer.
>>
>> cu andreas
> 
> If you download the last Ubuntu dsc for libgcrypt11
> 
> $ dget -u http://archive.ubuntu.com/ubuntu/pool/main/libg/libgcrypt11/libgcrypt11_1.5.0-3ubuntu2.1.dsc
> 
> 
> You will see that the patch they are carrying is the one that
> I put on the debdiff (no-global-init-thread-callbacks.diff)
> 
> 
> The previous patch (enable-global-init-secure-memory.patch)
> applied on libgcrypt11/1.5.0-3ubuntu1 was the one that caused
> the regression and was the patch reverted (.
> 
> 
> This one seems to be fine and don't cause regression.
> 
> 
> CC'ing Ubuntu maintainer.
> 
> 
> Adam, can you confirm if the patch no-global-init-thread-callbacks.diff
> is fine for fixing LP: #423252 or is causing some regression?
> 
> $ cat libgcrypt11-1.5.0/debian/patches/no-global-init-thread-callbacks.diff 
> --- a/src/global.c
> +++ b/src/global.c
> @@ -445,8 +445,6 @@
>  
>      case GCRYCTL_SET_THREAD_CBS:
>        err = ath_install (va_arg (arg_ptr, void *), any_init_done);
> -      if (! err)
> -	global_init ();
>        break;
>  
>      case GCRYCTL_FAST_POLL:
> 
> 
> 
> Thanks!
> 

Basically, this patch is reverting commit d769529a upstream

http://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commitdiff;h=d769529a


Its from 2005 :\

Squeeze version of libgcrypt11 has this code and don't causes this problem.


Why we are running into this bug now? 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnutls-maint/attachments/20130123/69299e49/attachment.pgp>