Bug#995049: p11-kit: FTBFS on hurd-i386
Svante Signell
svante.signell at gmail.com
Mon Sep 27 18:09:19 BST 2021
Hello Andreas
Just for your info. I’m AFK for another week so i cannot test anything until then. However, some comments are inlined below.
Skickat från min iPad
> 26 sep. 2021 kl. 14:35 skrev Andreas Metzler <ametzler at bebt.de>:
>
>> On 2021-09-25 Svante Signell <svante.signell at gmail.com> wrote:
>> Source: p11-kit
> [...]
>> Hi,
>
>> Currently p11-kit FTBFS on GNU/Hurd due to a missing implementation in
>> common/unix-peer.c. Fortunately the function getpeereid() is available
>> in the libbsd library. The same function is also available for
>> kFreeBSD.
>
> Hello Svante,
>
> thanks for your work.
>
>> The patch debian_control.diff adds a build dependency of
>> libbsd0 for kFreeBSD and Hurd.
>
> That should be libbsd-dev instead of libbsd0, shouldn't it?
>
Reasonably it should be, yes.
>> configure.ac.diff adds the bsd
>> library, while common_unix_peer.diff adds the declaration of the
>> function getpeereid(). This is added so that the header file
>> bsd/unistd.h is not necessarily included (which conflicts with parts
>> of unistd.h).
>
> How do these conflicts manifest? - I did not get additionial
> warnings/errors on hurd/kFreeBSD when including bsd/unistd.h instead of
> this declaration.
>
I included bsd/unistd.h without removing the inclusion of unistd.h in unix-peer.c. That did probably cause the problem.
>> Note that with the attached patches the patch,
>> 41_kfreebsd_LOCAL_PEERCRED.diff, for kFreeBSD is no longer needed.
>
>> The patches have been used to successfully build p11-kit on Linux,
>> Hurd and kFreeBSD.
>
> Afaict it does not change buildability on kFreeBSD
> though, should it?
>
> ERROR: test-managed
> ===================
>
> ./build/litter/tap-driver.sh: line 145: 90190 Illegal instruction "$@"
> ERROR: test-managed - missing test plan
>
> (Tested on on lemon.debian.net)
>
I did not build in a chroot, i used an uptodate (sid) qemu image of k-a. Kernel 11.0.
> cu Andreas
More information about the Pkg-gnutls-maint
mailing list