Bug#1040472: p11-kit FTCBFS: AC_RUN_IFELSE

Andreas Metzler ametzler at bebt.de
Sun Jul 9 15:04:20 BST 2023


On 2023-07-06 Helmut Grohne <helmut at subdivi.de> wrote:
> Source: p11-kit
[...]
> -		[AC_RUN_IFELSE(
> +		[AC_CACHE_CHECK([strerror_r return value],[ac_cv_strerror_r_ret],[
> +		     AC_RUN_IFELSE(
>  			[AC_LANG_SOURCE([[
>  				#include <errno.h>
>  				#include <string.h>
> @@ -178,10 +179,13 @@
>  					return strerror_r (EINVAL, buf, 32);
>  				}
>  			]])],
> +			[ac_cv_strerror_r_ret=xsi],
> +			[ac_cv_strerror_r_ret=gnu],
> +			[ac_cv_strerror_r_ret=cross])])
> +		 dnl Guess that we cross build on glibc
> +		 AS_IF([test "$ac_cv_strerror_r_ret" = xsi],
>                          [AC_DEFINE([HAVE_XSI_STRERROR_R], 1, [Whether XSI-compliant strerror_r() is available])],
> -			[AC_DEFINE([HAVE_GNU_STRERROR_R], 1, [Whether GNU-specific strerror_r() is available])],
> -			[])],
> -		[])
> +			[AC_DEFINE([HAVE_GNU_STRERROR_R], 1, [Whether GNU-specific strerror_r() is available])])])

>  	AC_CACHE_CHECK([for thread-local storage class],
>  		[ac_cv_tls_keyword],

Hello Helmut,

thanks.

I guess this should read 
AS_IF([test "$ac_cv_strerror_r_ret" = cross],

instead of

AS_IF([test "$ac_cv_strerror_r_ret" = xsi],

?

Also wouldn't using AC_FUNC_STRERROR_R be a better fix? (I do not expect
you to provide this, I asking for your opinion)

TIA, cu Andreas
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'



More information about the Pkg-gnutls-maint mailing list