[pkg-go] Sponsor needed for NEW package pt-websocket

[Ximin Luo]

On 01/06/14 12:44, Michael Stapelberg wrote:
> Hi Ximin,
> 
> Ximin Luo <infinity0 at pwned.gg> writes:
>>> Ximin Luo <infinity0 at pwned.gg> writes:
>>>> - override dh_auto_build and dh_auto_test to exclude
>>>> pt-websocket-client. This is because it depends on code not yet in
>>>> Debian (go.net/websocket). I agree it's nice to build it, but I don't
>>>> think we should block the release of this package to do so.
>>> Actually, I’d prefer to have websocket be in debian and this package to
>>> just use it. Otherwise we’ll end up with one more embedded source copy,
>>> and we already have way too many packages which do that.
>>>
>>
>> We don't embed any source copies, this is just *example code*. The
>> user needs to pull in go.net/websocket himself if he wants to build
>> it.
> Thanks for clarifying.
> 
>>>> override_dh_auto_build:
>>>> 	cd $(DH_BUILDDIR) && GOPATH=$$PWD go install -v $(DH_GOPKG_SUBDIRS:%=$(DH_GOPKG)/%)
>>>> 	make doc/pt-websocket-server.1
>>> This still sets GOPATH and hence suffers from the same problem I tried
>>> to point out in my last email on this thread.
>>>
>>> Please avoid calling go(1) directly at all in the entire Makefile and
>>> instead rely on dh_golang.
>>>
>>
>> Setting GOPATH like this is exactly what dh_golang does. I only
>> override it this way because dh_golang is not flexible enough, like I
>> explained in my last email. *I cannot use dh_golang.*
> Sorry, I didn’t pick up on the fact that dh_auto_configure is still run
> by dh_golang and hence you’ll get the properly set up build
> directory. This is okay for now, but in the long run it’d be good to
> switch to dh-golang after https://bugs.debian.org/734787 is fixed :).
> 
> I went ahead and uploaded the version currently in the
> repository. Thanks for your work!
> 

Thanks for the upload!

In future could you sign your git tags? `git tag -s` - we could add this to the team document too.

X

-- 
GPG: 4096R/1318EFAC5FBBDBCE
git://github.com/infinity0/pubkeys.git

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 880 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20140602/ec03cf69/attachment.sig>