[pkg-go] RFS: golang-revel

[Michael Stapelberg]

Sorry for the late reply, and thanks a lot for your packaging work!

General comments for all packages you listed in your email:

• Please use the same license for debian/ as for the rest of the package to
avoid headaches when adding a patch to the package.
• Feel free to bump urgency=low to urgency=medium for a quicker migration
to testing.

Comments which are specific to a package follow inline:

On Thu, May 14, 2015 at 6:33 AM, Potter, Tim (Cloud Services) <
timothy.potter at hp.com> wrote:

> Hi everyone.  I’ve made some progress packaging up the dependencies for
> fleet.  Or rather one of the dependencies for golang-libcontainer which is
> a dependency for fleet.  Can someone please take a look with a view to
> uploading these to unstable?
>
> I’ve got seven packages that make up the Go web framework, revel, at
> http://revel.github.io.  Here’s the list of packages, all of which are
> available for inspection under http://anonscm.debian.org/cgit/pkg-go
>
> * golang-revel (ITP: #785168)
>

With regards to
http://anonscm.debian.org/cgit/pkg-go/packages/golang-revel.git/tree/debian/patches/0001-reparent-x-net-websocket-modules.patch,
I think a new upload for x-net is being prepared by tincho at .

With regards to
http://anonscm.debian.org/cgit/pkg-go/packages/golang-revel.git/tree/debian/rules,
can you be more verbose about what the error is? Perhaps we can figure it
out.

The packaging itself LGTM, but I haven’t tested the build as I don’t want
to fiddle with my pbuilder setup right now and the dependencies aren’t
available in unstable yet.


> * golang-gocolorize (ITP: #785169)
>

LGTM.


> * golang-robfig-config (ITP: #785176)
>

Instead of adding a patch which effectively goes outside the build
directory (!), please set DH_GOLANG_INSTALL_ALL so that dh-golang will also
install the .cfg files.


> * golang-pathtree (ITP: #785179)
>

debian/docs is empty. Why keep it around?


> * golang-gomemcache (ITP: #785174)
>

LGTM.


> * golang-robfig-go-cache (ITP: #785175)
>

The override_dh_auto_install target seems useless, as it just calls
dh_auto_install…?


> * golang-redigo (ITP: #785172)
>

LGTM.


>
> There’s a question about some of the package names though.  I’ve named the
> github.com/robfig/config package golang-robfig-config since golang-config
> sounded too generic.  For golang-robfig-go-cache, since it is a fork of the
> canonical go-cache at github.com/pmylund/go-cache. Rob F’s version has
> unmarked commits from pmylund, but also some new commits that are used by
> Revel.
>
> I’ve tried to assume the Go module naming convention of
> github.com/username/reponame but with a golang prefix.  I’d appreciate
> some comments on this idea.
>
>
> Thanks,
>
> Tim.
> _______________________________________________
> Pkg-go-maintainers mailing list
> Pkg-go-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
>



-- 
Best regards,
Michael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20150520/da3e51bf/attachment.html>