[pkg-go] RFS: fleet -- Distributed init system using systemd and etcd

[Michael Stapelberg]

On Mon, Jun 1, 2015 at 8:03 AM, Potter, Tim (Cloud Services) <
timothy.potter at hp.com> wrote:

> On 5 May 2015, at 5:37 pm, Potter, Tim (Cloud Services) <
> timothy.potter at hp.com> wrote:
> >
> > On 5 May 2015, at 3:28 pm, Tianon Gravi <admwiggin at gmail.com> wrote:
> >>
> >> On 4 May 2015 at 23:11, Potter, Tim (Cloud Services)
> >> <timothy.potter at hp.com> wrote:
> >>> I’m a bit of a newcomer to Go but have done some Debian packaging
> before.  I think I’ve nailed all the big things but am more than happy to
> fix any broken-ness or policy issues that people can find.
> >>
> >> The big one I see is "4.13 Convenience copies of code" [1].  The Go
> >> packages in Godeps.json [2] will need to be individually packaged (if
> >> they aren't already) and added to Build-Depends (see other golang-*
> >> packages in pkg-go for examples), and the Godeps directly probably
> >> removed to be sure that it isn't used accidentally in place of the
> >> packaged variants.
> >
> > Hi Tianon.  Thanks for the reply.  Yes - oops that’s kind of a glaring
> problem with the package so far.  I’ll file some more ITP’s and post RFS’s
> to the list.
>
> Hello again everyone.  After a chat on IRC with tianon, I’ve whittled down
> the required dependencies for fleet by a lot.  Most of the ITP’s I created
> were for libcontainer, which turns out to be already present in
> golang-docker-dev.  This means a lot of wasted work but hey I know a lot
> more about Go than before!
>
> The final list of packages for fleet is:
>
> * fleet
>

This requires the rest, so I’ll hold off reviewing it.


> * golang-clockwork
>

Uploaded.


> * golang-globalconf
>

Please kill debian/patches/0002-fix-path-for-tests.patch and
export DH_GOLANG_INSTALL_ALL := 1 in debian/rules instead.

* golang-go-semver
>

Uploaded.


> * golang-go-uuid
>

The project has moved to https://github.com/pborman/uuid, can you reflect
that in the Homepage: field and DH_GOPKG please?

Additionally, the build fails for me because of a failing test:

--- FAIL: TestNodeID (0.00s)
uuid_test.go:315: NodeInterface "" after SetInteface

* golang-goini
>

Please kill debian/patches/0001-fix-path-for-tests.patch and
export DH_GOLANG_INSTALL_ALL := 1 in debian/rules instead.


> * golang-go-systemd (>= 2~git20150505)
>

As written in the other thread, please push your changes and I can
review/sponsor.


>
> That’s a much more manageable list really.
>
> Changes made since I posted this original email:
>
> * verified license for debian/* identical to package license
> * removed convencience copies of code for fleet
> * set urgency=medium in d/changelog
>
> Note that an update to golang-go-systemd to add some new files is
> required, which I’ve just send another email about.
>
> Thanks!
>
>
> Tim.
>
>
> _______________________________________________
> Pkg-go-maintainers mailing list
> Pkg-go-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
>



-- 
Best regards,
Michael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20150608/7360c32a/attachment-0001.html>