[pkg-go] Changing dh-golang to work with Go shared libraries

Michael Hudson-Doyle michael.hudson at canonical.com
Thu Jun 18 22:16:26 UTC 2015


On 19 June 2015 at 08:24, Michael Stapelberg <stapelberg at debian.org> wrote:
> Thanks.
>
> The overall approach looks good to me,

Very glad to hear that :-)

> but the patches still contain a fair
> number of TODOs — I assume you’ll address them before sending them for a
> merge?

Oh yes, sorry, I actually meant to fix some of those before sending
the patches (the ones asking if changes are still necessary) but
clearly forgot. I'll certainly get those cleaned up before sending a
patch in for merging.

For this one:

+    # XXX Could do some consistency checks here e.g
+    # 1) make sure there is a devpkg if there is a libpkg
+    # 2) make sure devpkg depends on libpkg
+    # 3) make sure libpkg has "Provides: ${golang:Provides}"
+    # Maybe this is more in the realm of lintian.

I'd welcome your input -- do you think it makes sense to check those
things here?  If so, I'll add the checks, if not, I'll just delete the
comment :-)

> Also, I think it’d be prudent to upload the next version of dh-golang to
> experimental first so that people can actually try out the shared library
> mode and send some feedback based on real-life usage before we upload
> dh-golang to unstable and hence commit to maintaining that feature.

Oh yes, definitely. We'd also need golang-shared-dev (or whatever that
ends up being called) in experimental too, and that's not going to
happen for a little while...

Cheers,
mwh

> On Tue, Jun 16, 2015 at 5:02 AM, Michael Hudson-Doyle
> <michael.hudson at canonical.com> wrote:
>>
>> Hi,
>>
>> Some of you have already seen and commented on my proposal on how to
>> change dh-golang to build and link against Go shared libraries, coming
>> (on amd64 at least) in Go 1.5:
>>
>> https://docs.google.com/document/d/1IOlBWWgcDeB9PfRORENESYj8iJt4W2EwsbYcpg4akBE/edit#heading=h.j590j9v4qbxg.
>> I've just made some small edits to it around the name of the shared
>> objects that are built.
>>
>> I'm attaching two patches that implement the scheme described in the
>> doc. I've not tested them super extensively but they do seem to work
>> (with a go package from my branch at
>> https://github.com/mwhudson/go/tree/ubuntu-vivid, ignore the branch
>> name, it builds fine on sid).
>>
>> I'd be most interested in any comments anyone has.
>>
>> Cheers,
>> mwh
>>
>> _______________________________________________
>> Pkg-go-maintainers mailing list
>> Pkg-go-maintainers at lists.alioth.debian.org
>> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
>
>
>
>
> --
> Best regards,
> Michael



More information about the Pkg-go-maintainers mailing list