[pkg-go] Bug#792704: Bug#792704: etcd: Allow etcd configuration with systemd unit file

[Michael Stapelberg]

I understand that you like environment files better, but they are not
systemd’s idiomatic mechanism for overwriting configuration directives.

I feel like we should not have etcd be a special case here just to
accomodate personal, subjective taste. Consider that systemd’s mechanism
works for every single service file, whereas with your suggestion, we’d
need to _modify_ every single service file in Debian — that does not strike
me as a good approach.

If you think Debian should generally use environment files to customize
systemd service files, feel free to start a discussion about that on
debian-devel. If it turns out that Debian as a project wants to go that
route, I’m happy to change the service file. Until then, I’d prefer it if
we could stick to the tools that systemd already brings to the table.

On Fri, Jul 17, 2015 at 6:00 PM, Paris, Eric <eparis at parisplace.org> wrote:

> With sysinit I can have a config file (/etc/default/etcd). I really
> like normal config files, which provisioning tools like
> salt,puppet,ansible and sysadmins can manage. You are right, today you
> could create etcd.service.d/override.conf, but the language in there
> is terrible. Like you pointed out, this is systemd configuration not
> etcd configuration, you have to prepend everything with Environment=
>
> Why wouldn't I just want an EnvironmentFile= something?  (Preferably
> after the two Environment= hard coded into the unit file) so we can
> have something easily usable by both humans and provisioning tools...
>
> On Fri, Jul 17, 2015 at 12:44 PM, Michael Stapelberg
> <stapelberg at debian.org> wrote:
> > Why is not good enough to use systemd’s ways to override specific keys
> of a
> > service file? I.e., use “systemctl edit etcd” and specify e.g.
> > Environment=ETCD_DATA_DIR=/my/path/to/etcd
> >
> > On Fri, Jul 17, 2015 at 4:27 PM, Eric Paris <debianbugs at parisplace.org>
> > wrote:
> >>
> >> Package: etcd
> >> Version: 2.0.8-2
> >> Severity: wishlist
> >>
> >> Dear Maintainer,
> >>
> >> The systemd unit file hard codes a working dir and name. It does not
> have
> >> any mechanism for additional configuration. Personally I like the Fedora
> >> systemd unit file
> >>
> >> http://pkgs.fedoraproject.org/cgit/etcd.git/tree/etcd.service
> >>
> >> Which uses /etc/etcd/etcd.conf as the ENV file.
> >>
> >> The sysinit scripts use /etc/default/etcd but the ENV keys in that file
> >> are not the ENV keys which etcd pays attention to. But there should be
> some
> >> way, when using systemd to configure it.
> >>
> >> I got my instalation to work by just putting the Fedora .service file
> into
> >> /etc/systemd/system, but a reasonable default in /lib seems like a good
> >> idea.
> >>
> >> -- System Information:
> >> Debian Release: 8.1
> >>   APT prefers stable-updates
> >>   APT policy: (500, 'stable-updates'), (500, 'stable'), (1,
> >> 'experimental')
> >> Architecture: amd64 (x86_64)
> >>
> >> Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
> >> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> >> Shell: /bin/sh linked to /bin/dash
> >> Init: systemd (via /run/systemd/system)
> >>
> >> Versions of packages etcd depends on:
> >> ii  adduser  3.113+nmu3
> >> ii  libc6    2.19-18
> >>
> >> etcd recommends no packages.
> >>
> >> etcd suggests no packages.
> >>
> >> -- Configuration Files:
> >> /etc/default/etcd changed [not included]
> >> /etc/init.d/etcd changed [not included]
> >>
> >> -- no debconf information
> >>
> >> _______________________________________________
> >> Pkg-go-maintainers mailing list
> >> Pkg-go-maintainers at lists.alioth.debian.org
> >>
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
> >
> >
> >
> >
> > --
> > Best regards,
> > Michael
>



-- 
Best regards,
Michael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20150717/25e8276b/attachment.html>